Re: svn commit: r288099 - head/contrib/binutils/opcodes

2015-09-22 Thread Dimitry Andric
On 22 Sep 2015, at 16:23, Ian Lepore wrote: > > On Tue, 2015-09-22 at 11:53 +0200, Dimitry Andric wrote: >> On 22 Sep 2015, at 11:43, Slawa Olhovchenkov wrote: >>> >>> On Tue, Sep 22, 2015 at 09:35:35AM +, Dimitry Andric wrote: >> ... -imm |= (-1 << 7); +

Re: svn commit: r288099 - head/contrib/binutils/opcodes

2015-09-22 Thread Slawa Olhovchenkov
On Tue, Sep 22, 2015 at 08:23:07AM -0600, Ian Lepore wrote: > On Tue, 2015-09-22 at 11:53 +0200, Dimitry Andric wrote: > > On 22 Sep 2015, at 11:43, Slawa Olhovchenkov wrote: > > > > > > On Tue, Sep 22, 2015 at 09:35:35AM +, Dimitry Andric wrote: > > ... > > >> - imm

Re: svn commit: r288099 - head/contrib/binutils/opcodes

2015-09-22 Thread Ian Lepore
On Tue, 2015-09-22 at 11:53 +0200, Dimitry Andric wrote: > On 22 Sep 2015, at 11:43, Slawa Olhovchenkov wrote: > > > > On Tue, Sep 22, 2015 at 09:35:35AM +, Dimitry Andric wrote: > ... > >> -imm |= (-1 << 7); > >> +imm |= -(1 << 7); > > > > May be (~0

Re: svn commit: r288099 - head/contrib/binutils/opcodes

2015-09-22 Thread Slawa Olhovchenkov
On Tue, Sep 22, 2015 at 11:53:32AM +0200, Dimitry Andric wrote: > On 22 Sep 2015, at 11:43, Slawa Olhovchenkov wrote: > > > > On Tue, Sep 22, 2015 at 09:35:35AM +, Dimitry Andric wrote: > ... > >> -imm |= (-1 << 7); > >> +imm |= -(1 << 7); > > > > May

Re: svn commit: r288099 - head/contrib/binutils/opcodes

2015-09-22 Thread Dimitry Andric
On 22 Sep 2015, at 11:43, Slawa Olhovchenkov wrote: > > On Tue, Sep 22, 2015 at 09:35:35AM +, Dimitry Andric wrote: ... >> - imm |= (-1 << 7); >> + imm |= -(1 << 7); > > May be (~0 << 7) is more simple to understund? This will give the same warning.

Re: svn commit: r288099 - head/contrib/binutils/opcodes

2015-09-22 Thread Slawa Olhovchenkov
On Tue, Sep 22, 2015 at 09:35:35AM +, Dimitry Andric wrote: > Author: dim > Date: Tue Sep 22 09:35:35 2015 > New Revision: 288099 > URL: https://svnweb.freebsd.org/changeset/base/288099 > > Log: > In binutils' arm-dis.c, avoid left-shifting a negative number. > > Submitted by: da

svn commit: r288099 - head/contrib/binutils/opcodes

2015-09-22 Thread Dimitry Andric
Author: dim Date: Tue Sep 22 09:35:35 2015 New Revision: 288099 URL: https://svnweb.freebsd.org/changeset/base/288099 Log: In binutils' arm-dis.c, avoid left-shifting a negative number. Submitted by: dan.mcgregor_usask.ca (Dan McGregor) MFC after:3 days Differential Revision: https: