Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-29 Thread Bruce Evans
On Tue, 29 Dec 2015, Dmitry Chagin wrote: So, my point was: a) for a long time we have broken settimeofday() which does not allow us to set the system time before the Epoch We still have a broken settimeofday that doesn't allow us to set the system time to the Epoch in the Western hemisphere

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-29 Thread Dmitry Chagin
2015-12-28 1:35 GMT+03:00 Bruce Evans : > On Sun, 27 Dec 2015, Ian Lepore wrote: > > On Sun, 2015-12-27 at 15:37 +, Dmitry Chagin wrote: >> >>> Author: dchagin >>> Date: Sun Dec 27 15:37:07 2015 >>> New Revision: 292777 >>> URL: https://svnweb.freebsd.org/changeset/base/292777 >>> >>> Log: >>>

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-28 Thread Bruce Evans
On Mon, 28 Dec 2015, Garrett Cooper wrote: On Dec 28, 2015, at 02:17, Bruce Evans wrote: ... It is not unreasonable to panic when such tests fail, just like for other settings of unreasonable values. Only the superuser can make them, and the superuser should know better than to run them

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-28 Thread Garrett Cooper
> On Dec 28, 2015, at 02:17, Bruce Evans wrote: ... > It is not unreasonable to panic when such tests fail, just like for other > settings of unreasonable values. Only the superuser can make them, and > the superuser should know better than to run them on production systems. On a development

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-28 Thread Slawa Olhovchenkov
On Mon, Dec 28, 2015 at 09:17:50PM +1100, Bruce Evans wrote: > On Mon, 28 Dec 2015, Konstantin Belousov wrote: > > > On Mon, Dec 28, 2015 at 09:35:11AM +1100, Bruce Evans wrote: > >> If this causes a panic, then it is from a sanity check detecting the > >> invalid conversion later. A negative va

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-28 Thread Bruce Evans
On Mon, 28 Dec 2015, Konstantin Belousov wrote: On Mon, Dec 28, 2015 at 09:35:11AM +1100, Bruce Evans wrote: If this causes a panic, then it is from a sanity check detecting the invalid conversion later. A negative value in days breaks the loop logic but seems to give premature exit from the l

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-28 Thread Konstantin Belousov
On Mon, Dec 28, 2015 at 09:35:11AM +1100, Bruce Evans wrote: > If this causes a panic, then it is from a sanity check detecting the > invalid conversion later. A negative value in days breaks the loop > logic but seems to give premature exit from the loops instead of many > iterations. It causes t

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread Julian Elischer
On 28/12/2015 7:23 AM, Bruce Evans wrote: On Sun, 27 Dec 2015, Ian Lepore wrote: On Sun, 2015-12-27 at 12:05 -0800, NGie Cooper wrote: On Dec 27, 2015, at 11:30, Slawa Olhovchenkov wrote: � I have no idea what you mean by that -- I didn't say anything at all about panic. As I understund

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread Bruce Evans
On Sun, 27 Dec 2015, Ian Lepore wrote: On Sun, 2015-12-27 at 12:05 -0800, NGie Cooper wrote: On Dec 27, 2015, at 11:30, Slawa Olhovchenkov wrote: ? I have no idea what you mean by that -- I didn't say anything at all about panic. As I understund commit log -- this is prevent kernel panic

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread Bruce Evans
On Sun, 27 Dec 2015, Ian Lepore wrote: On Sun, 2015-12-27 at 15:37 +, Dmitry Chagin wrote: Author: dchagin Date: Sun Dec 27 15:37:07 2015 New Revision: 292777 URL: https://svnweb.freebsd.org/changeset/base/292777 Log: Verify that tv_sec value specified in settimeofday() and clock_settime

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread Ian Lepore
On Sun, 2015-12-27 at 12:05 -0800, NGie Cooper wrote: > > On Dec 27, 2015, at 11:30, Slawa Olhovchenkov > > wrote: > > … > > > > I have no idea what you mean by that -- I didn't say anything at > > > all > > > about panic. > > > > As I understund commit log -- this is prevent kernel panic at so

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread NGie Cooper
> On Dec 27, 2015, at 11:30, Slawa Olhovchenkov wrote: … >> I have no idea what you mean by that -- I didn't say anything at all >> about panic. > > As I understund commit log -- this is prevent kernel panic at some > call (with illegal arguments). This accpetable irrelevant to bugs in > calli

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread Slawa Olhovchenkov
On Sun, Dec 27, 2015 at 12:16:50PM -0700, Ian Lepore wrote: > On Sun, 2015-12-27 at 21:41 +0300, Slawa Olhovchenkov wrote: > > On Sun, Dec 27, 2015 at 10:10:37AM -0700, Ian Lepore wrote: > > > > > On Sun, 2015-12-27 at 15:37 +, Dmitry Chagin wrote: > > > > Author: dchagin > > > > Date: Sun De

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread Ian Lepore
On Sun, 2015-12-27 at 21:41 +0300, Slawa Olhovchenkov wrote: > On Sun, Dec 27, 2015 at 10:10:37AM -0700, Ian Lepore wrote: > > > On Sun, 2015-12-27 at 15:37 +, Dmitry Chagin wrote: > > > Author: dchagin > > > Date: Sun Dec 27 15:37:07 2015 > > > New Revision: 292777 > > > URL: https://svnweb.f

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread Slawa Olhovchenkov
On Sun, Dec 27, 2015 at 10:10:37AM -0700, Ian Lepore wrote: > On Sun, 2015-12-27 at 15:37 +, Dmitry Chagin wrote: > > Author: dchagin > > Date: Sun Dec 27 15:37:07 2015 > > New Revision: 292777 > > URL: https://svnweb.freebsd.org/changeset/base/292777 > > > > Log: > > Verify that tv_sec val

Re: svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread Ian Lepore
On Sun, 2015-12-27 at 15:37 +, Dmitry Chagin wrote: > Author: dchagin > Date: Sun Dec 27 15:37:07 2015 > New Revision: 292777 > URL: https://svnweb.freebsd.org/changeset/base/292777 > > Log: > Verify that tv_sec value specified in settimeofday() and > clock_settime() > (CLOCK_REALTIME case

svn commit: r292777 - in head: lib/libc/sys sys/kern

2015-12-27 Thread Dmitry Chagin
Author: dchagin Date: Sun Dec 27 15:37:07 2015 New Revision: 292777 URL: https://svnweb.freebsd.org/changeset/base/292777 Log: Verify that tv_sec value specified in settimeofday() and clock_settime() (CLOCK_REALTIME case) system calls is non negative. This commit hides a kernel panic in atrt