Re: svn commit: r313821 - in head/sys: dev/cxgb/ulp/iw_cxgb fs/nfsserver kern netinet netinet/libalias netpfil/ipfw

2017-02-17 Thread Eric van Gyzen
On 02/16/2017 22:17, Gleb Smirnoff wrote: Eric, heh, things are worse. Multiple places you changes are CTR() macros. Neither inet_ntoa() nor inet_ntoa_r() will work with them. :( Basicly non-constant strings can not be logged with KTR. All the lines you touched should log actual binary

Re: svn commit: r313821 - in head/sys: dev/cxgb/ulp/iw_cxgb fs/nfsserver kern netinet netinet/libalias netpfil/ipfw

2017-02-16 Thread Bruce Evans
On Thu, 16 Feb 2017, Gleb Smirnoff wrote: heh, things are worse. Multiple places you changes are CTR() macros. Neither inet_ntoa() nor inet_ntoa_r() will work with them. :( Basicly non-constant strings can not be logged with KTR. All the lines you touched should log actual binary value of the

Re: svn commit: r313821 - in head/sys: dev/cxgb/ulp/iw_cxgb fs/nfsserver kern netinet netinet/libalias netpfil/ipfw

2017-02-16 Thread Gleb Smirnoff
Eric, heh, things are worse. Multiple places you changes are CTR() macros. Neither inet_ntoa() nor inet_ntoa_r() will work with them. :( Basicly non-constant strings can not be logged with KTR. All the lines you touched should log actual binary value of the IPv4 address. I am not asking you

Re: svn commit: r313821 - in head/sys: dev/cxgb/ulp/iw_cxgb fs/nfsserver kern netinet netinet/libalias netpfil/ipfw

2017-02-16 Thread Gleb Smirnoff
On Thu, Feb 16, 2017 at 08:47:41PM +, Eric van Gyzen wrote: E> Author: vangyzen E> Date: Thu Feb 16 20:47:41 2017 E> New Revision: 313821 E> URL: https://svnweb.freebsd.org/changeset/base/313821 E> E> Log: E> Use inet_ntoa_r() instead of inet_ntoa() throughout the kernel E> E>

svn commit: r313821 - in head/sys: dev/cxgb/ulp/iw_cxgb fs/nfsserver kern netinet netinet/libalias netpfil/ipfw

2017-02-16 Thread Eric van Gyzen
Author: vangyzen Date: Thu Feb 16 20:47:41 2017 New Revision: 313821 URL: https://svnweb.freebsd.org/changeset/base/313821 Log: Use inet_ntoa_r() instead of inet_ntoa() throughout the kernel inet_ntoa() cannot be used safely in a multithreaded environment because it uses a static local