Re: svn commit: r331369 - head/sys/vm

2018-04-07 Thread Bruce Evans
On Sat, 7 Apr 2018, Cy Schubert wrote: In message <201803230615.w2n6ftmj040...@slippy.cwsent.com>, Cy Schubert writes: In message <20180323150709.h...@besplex.bde.org>, Bruce Evans writes: On Thu, 22 Mar 2018, Jeff Roberson wrote: On Thu, 22 Mar 2018, Cy Schubert wrote: It broke i386 too.

Re: svn commit: r331369 - head/sys/vm

2018-04-07 Thread Cy Schubert
In message <201803230615.w2n6ftmj040...@slippy.cwsent.com>, Cy Schubert writes: > In message <20180323150709.h...@besplex.bde.org>, Bruce Evans writes: > > On Thu, 22 Mar 2018, Jeff Roberson wrote: > > > > > On Thu, 22 Mar 2018, Cy Schubert wrote: > > > > > >> It broke i386 too. > > > > > > I just

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Cy Schubert
In message <20180323150709.h...@besplex.bde.org>, Bruce Evans writes: > On Thu, 22 Mar 2018, Jeff Roberson wrote: > > > On Thu, 22 Mar 2018, Cy Schubert wrote: > > > >> It broke i386 too. > > > > I just did > > TARGET_ARCH=i386 make buildworld > > TARGET_ARCH=i386 make buildkernel > > > > This work

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Bruce Evans
On Thu, 22 Mar 2018, Jeff Roberson wrote: On Thu, 22 Mar 2018, Cy Schubert wrote: It broke i386 too. I just did TARGET_ARCH=i386 make buildworld TARGET_ARCH=i386 make buildkernel This worked for me? Index: sys/vm/vm_reserv.c

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Cy Schubert
In message , Jeff Roberson writes: > On Thu, 22 Mar 2018, Cy Schubert wrote: > > > In message , Jeff Roberson > > writes: > >> On Thu, 22 Mar 2018, Cy Schubert wrote: > >> > >>> It broke i386 too. > >> > >> I just did > >> TARGET_ARCH=i386 make buildworld > >> TARGET_ARCH=i386 make buildkernel > >

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Cy Schubert
In message , Jeff Roberson writes: > On Thu, 22 Mar 2018, Cy Schubert wrote: > > > It broke i386 too. > > I believe I'm not able to reproduce this because it is a result of changes > in kernel config. I can not reproduce it so I can't verify the fix. > Since you can, would you mind committing?

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Jeff Roberson
On Thu, 22 Mar 2018, Cy Schubert wrote: In message , Jeff Roberson writes: On Thu, 22 Mar 2018, Cy Schubert wrote: It broke i386 too. I just did TARGET_ARCH=i386 make buildworld TARGET_ARCH=i386 make buildkernel This worked for me? Jeff hmmm. make TARGET=i386 TARGET_ARCH=i386 buildkern

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Cy Schubert
In message , Jeff Roberson writes: > On Thu, 22 Mar 2018, Cy Schubert wrote: > > > It broke i386 too. > > I just did > TARGET_ARCH=i386 make buildworld > TARGET_ARCH=i386 make buildkernel > > This worked for me? > > Jeff hmmm. make TARGET=i386 TARGET_ARCH=i386 buildkernel --- vm_reserv.o --- In

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Jeff Roberson
On Thu, 22 Mar 2018, Cy Schubert wrote: It broke i386 too. I believe I'm not able to reproduce this because it is a result of changes in kernel config. I can not reproduce it so I can't verify the fix. Since you can, would you mind committing? I see no problem with the diff below. Thank

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Jeff Roberson
On Thu, 22 Mar 2018, Cy Schubert wrote: It broke i386 too. I just did TARGET_ARCH=i386 make buildworld TARGET_ARCH=i386 make buildkernel This worked for me? Jeff Index: sys/vm/vm_reserv.c === --- sys/vm/vm_reserv.c (revision

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Cy Schubert
It broke i386 too. Index: sys/vm/vm_reserv.c === --- sys/vm/vm_reserv.c (revision 331399) +++ sys/vm/vm_reserv.c (working copy) @@ -45,8 +45,6 @@ #include #include -#include -#include #include #include #include @@ -55,

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Jeff Roberson
Thank you, working on it. I had done a make universe before getting review feedback. Jeff On Thu, 22 Mar 2018, Justin Hibbits wrote: This broke gcc builds. On Thu, Mar 22, 2018 at 2:21 PM, Jeff Roberson wrote: Author: jeff Date: Thu Mar 22 19:21:11 2018 New Revision: 331369 URL: https://s

Re: svn commit: r331369 - head/sys/vm

2018-03-22 Thread Justin Hibbits
This broke gcc builds. On Thu, Mar 22, 2018 at 2:21 PM, Jeff Roberson wrote: > Author: jeff > Date: Thu Mar 22 19:21:11 2018 > New Revision: 331369 > URL: https://svnweb.freebsd.org/changeset/base/331369 > > Log: > Lock reservations with a dedicated lock in each reservation. Protect the > vm

svn commit: r331369 - head/sys/vm

2018-03-22 Thread Jeff Roberson
Author: jeff Date: Thu Mar 22 19:21:11 2018 New Revision: 331369 URL: https://svnweb.freebsd.org/changeset/base/331369 Log: Lock reservations with a dedicated lock in each reservation. Protect the vmd_free_count with atomics. This allows us to allocate and free from reservations without