Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-19 Thread Allan Jude
On 2018-04-16 8:02 PM, Rick Macklem wrote: I wrote: Julian Elischer wrote: On 16/4/18 6:56 pm, Konstantin Belousov wrote: [stuff snipped] +ngroups =3D XU_NGROUPS + 1; Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ? valid question.. because that is how many

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-18 Thread Julian Elischer
On 19/4/18 5:15 am, Rick Macklem wrote: Julian Elischer wrote: [stuff snipped] our issue is that we make a server that combines CIFS/SMB access (via samba), credential setting from a company wide AD server (windows) via winbindd (samba) via nsswitch.. and NFS. The problem is that when one

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-18 Thread Rick Macklem
Julian Elischer wrote: [stuff snipped] >our issue is that we make a server that combines CIFS/SMB access (via >samba), credential setting from a company wide AD server (windows) >via winbindd (samba) via nsswitch.. and NFS. > >The problem is that when one looks up a user name from the AD server

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-17 Thread Julian Elischer
On 17/4/18 8:32 pm, Konstantin Belousov wrote: On Tue, Apr 17, 2018 at 12:02:04AM +, Rick Macklem wrote: I wrote: Julian Elischer wrote: On 16/4/18 6:56 pm, Konstantin Belousov wrote: [stuff snipped] +ngroups =3D XU_NGROUPS + 1; Why XU_NGROUPS and not the value of

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-17 Thread Konstantin Belousov
On Tue, Apr 17, 2018 at 12:02:04AM +, Rick Macklem wrote: > I wrote: > >Julian Elischer wrote: > >>On 16/4/18 6:56 pm, Konstantin Belousov wrote: > >[stuff snipped] > +ngroups =3D XU_NGROUPS + 1; > >>> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ? >

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-16 Thread Rick Macklem
I wrote: >Julian Elischer wrote: >>On 16/4/18 6:56 pm, Konstantin Belousov wrote: >[stuff snipped] +ngroups =3D XU_NGROUPS + 1; >>> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ? >>valid question.. because that is how many are allocated? >>it was a "minimally

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-16 Thread Rick Macklem
Julian Elischer wrote: >On 16/4/18 6:56 pm, Konstantin Belousov wrote: [stuff snipped] >>> +ngroups = XU_NGROUPS + 1; >> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ? >valid question.. because that is how many are allocated? >it was a "minimally invasive patch"..

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-16 Thread Julian Elischer
On 16/4/18 6:56 pm, Konstantin Belousov wrote: On Mon, Apr 16, 2018 at 09:17:36AM +, Andriy Gapon wrote: Author: avg Date: Mon Apr 16 09:17:36 2018 New Revision: 332559 URL: https://svnweb.freebsd.org/changeset/base/332559 Log: mountd: fix a crash when getgrouplist reports too many

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-16 Thread Andriy Gapon
On 16/04/2018 13:56, Konstantin Belousov wrote: > On Mon, Apr 16, 2018 at 09:17:36AM +, Andriy Gapon wrote: >> Author: avg >> Date: Mon Apr 16 09:17:36 2018 >> New Revision: 332559 >> URL: https://svnweb.freebsd.org/changeset/base/332559 >> >> Log: >> mountd: fix a crash when getgrouplist

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-16 Thread Konstantin Belousov
On Mon, Apr 16, 2018 at 09:17:36AM +, Andriy Gapon wrote: > Author: avg > Date: Mon Apr 16 09:17:36 2018 > New Revision: 332559 > URL: https://svnweb.freebsd.org/changeset/base/332559 > > Log: > mountd: fix a crash when getgrouplist reports too many groups > > Previously the code only

svn commit: r332559 - head/usr.sbin/mountd

2018-04-16 Thread Andriy Gapon
Author: avg Date: Mon Apr 16 09:17:36 2018 New Revision: 332559 URL: https://svnweb.freebsd.org/changeset/base/332559 Log: mountd: fix a crash when getgrouplist reports too many groups Previously the code only warned about the condition and then happily proceeded to use the too large