Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-06 Thread Bruce Evans
On Sat, 5 May 2018, Mateusz Guzik wrote: On Sat, May 5, 2018 at 2:00 PM, Alexey Dokuchaev wrote: On Sat, May 05, 2018 at 10:38:29AM +1000, Bruce Evans wrote: ... Summary: this change wouldn't have passed my review. I have used similar changes for 15-20 years but never made them production q

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-05 Thread Bruce Evans
On Sat, 5 May 2018, Mateusz Guzik wrote: On Sat, May 5, 2018 at 2:38 AM, Bruce Evans wrote: I don't believe the claimed speeding of using the optimized bcopy() in cpu_fetch_sycall_args() on amd64 (r333241). This changes the copy size from a variable to 6*8 bytes. It is claimed to speed up g

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-05 Thread Mateusz Guzik
On Sat, May 5, 2018 at 2:00 PM, Alexey Dokuchaev wrote: > On Sat, May 05, 2018 at 10:38:29AM +1000, Bruce Evans wrote: > > ... > > Summary: this change wouldn't have passed my review. I have used similar > > changes for 15-20 years but never made them production quality since > there > > are too

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-05 Thread Mateusz Guzik
On Sat, May 5, 2018 at 2:38 AM, Bruce Evans wrote: I don't believe the claimed speeding of using the optimized bcopy() > in cpu_fetch_sycall_args() on amd64 (r333241). This changes the copy > size from a variable to 6*8 bytes. It is claimed to speed up getppid() > from 7.31M/sec to 10.65M/sec o

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-05 Thread Alexey Dokuchaev
On Sat, May 05, 2018 at 10:38:29AM +1000, Bruce Evans wrote: > ... > Summary: this change wouldn't have passed my review. I have used similar > changes for 15-20 years but never made them production quality since there > are too many variations to consider and testing showed insignificant > improv

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-04 Thread Bruce Evans
On Sat, 5 May 2018, Mateusz Guzik wrote: On Fri, May 4, 2018 at 5:53 PM, Brooks Davis wrote: On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: Author: mjg Date: Fri May 4 04:00:48 2018 New Revision: 333240 URL: https://svnweb.freebsd.org/changeset/base/333240 Log: Allow __bu

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-04 Thread Bruce Evans
On Fri, 4 May 2018, Conrad Meyer wrote: On Fri, May 4, 2018 at 8:53 AM, Brooks Davis wrote: On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: Author: mjg Date: Fri May 4 04:00:48 2018 New Revision: 333240 URL: https://svnweb.freebsd.org/changeset/base/333240 Log: Allow __buil

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-04 Thread Mateusz Guzik
On Fri, May 4, 2018 at 5:53 PM, Brooks Davis wrote: > On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: > > Author: mjg > > Date: Fri May 4 04:00:48 2018 > > New Revision: 333240 > > URL: https://svnweb.freebsd.org/changeset/base/333240 > > > > Log: > > Allow __builtin_memmove ins

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-04 Thread Conrad Meyer
On Fri, May 4, 2018 at 8:53 AM, Brooks Davis wrote: > On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: >> Author: mjg >> Date: Fri May 4 04:00:48 2018 >> New Revision: 333240 >> URL: https://svnweb.freebsd.org/changeset/base/333240 >> >> Log: >> Allow __builtin_memmove instead of

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-04 Thread Brooks Davis
On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: > Author: mjg > Date: Fri May 4 04:00:48 2018 > New Revision: 333240 > URL: https://svnweb.freebsd.org/changeset/base/333240 > > Log: > Allow __builtin_memmove instead of bcopy for small buffers of known size What is the justificat

svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-03 Thread Mateusz Guzik
Author: mjg Date: Fri May 4 04:00:48 2018 New Revision: 333240 URL: https://svnweb.freebsd.org/changeset/base/333240 Log: Allow __builtin_memmove instead of bcopy for small buffers of known size See r323329 for an explanation why this is a good idea. Modified: head/sys/powerpc/powerpc/b