Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Bruce Evans
On Tue, 8 May 2018, Bruce Evans wrote: On Mon, 7 May 2018, Mateusz Guzik wrote: Log: amd64: replace libkern's memset and memmove with assembly variants ... memset is repurposed memcpy. The librkern variant is doing fishy stuff, including branching on 0 and calling bzero. You mean the old

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Bruce Evans
On Mon, 7 May 2018, Mateusz Guzik wrote: Log: amd64: replace libkern's memset and memmove with assembly variants memmove is repurposed bcopy (arguments swapped, return value added) The libkern variant is a wrapper around bcopy, so this is a big improvement. This is a tiny improvement, per

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Mateusz Guzik
On Mon, May 7, 2018 at 9:03 PM, Oliver Pinter wrote: > On 5/7/18, Mateusz Guzik wrote: > > Author: mjg > > Date: Mon May 7 15:07:28 2018 > > New Revision: 24 > > URL: https://svnweb.freebsd.org/changeset/base/24 > > > > Log: > > amd64: replace libkern's memset and memmove with assembl

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Oliver Pinter
On 5/7/18, Rodney W. Grimes wrote: >> Author: mjg >> Date: Mon May 7 15:07:28 2018 >> New Revision: 24 >> URL: https://svnweb.freebsd.org/changeset/base/24 >> >> Log: >> amd64: replace libkern's memset and memmove with assembly variants >> >> memmove is repurposed bcopy (arguments swa

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Oliver Pinter
On 5/7/18, Oliver Pinter wrote: > On 5/7/18, Mateusz Guzik wrote: >> Author: mjg >> Date: Mon May 7 15:07:28 2018 >> New Revision: 24 >> URL: https://svnweb.freebsd.org/changeset/base/24 >> >> Log: >> amd64: replace libkern's memset and memmove with assembly variants >> >> memmove is

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Oliver Pinter
On 5/7/18, Mateusz Guzik wrote: > Author: mjg > Date: Mon May 7 15:07:28 2018 > New Revision: 24 > URL: https://svnweb.freebsd.org/changeset/base/24 > > Log: > amd64: replace libkern's memset and memmove with assembly variants > > memmove is repurposed bcopy (arguments swapped, return

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > On Mon, May 7, 2018 at 11:28 AM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > On Mon, May 7, 2018 at 10:26 AM, Conrad Meyer wrote: > > > > > > > On Mon, May 7, 2018 at 8:45 AM, R

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Warner Losh
On Mon, May 7, 2018 at 11:28 AM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > On Mon, May 7, 2018 at 10:26 AM, Conrad Meyer wrote: > > > > > On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes > > > wrote: > > > >> + * w...@tools.de

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > On Mon, May 7, 2018 at 10:26 AM, Conrad Meyer wrote: > > > On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes > > wrote: > > >> + * w...@tools.de (Wolfgang Solfrank, TooLs GmbH) +49-228-985800 > > > > > > If the original is by w...@tools.de, who

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Warner Losh
On Mon, May 7, 2018 at 10:26 AM, Conrad Meyer wrote: > On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes > wrote: > >> + * w...@tools.de (Wolfgang Solfrank, TooLs GmbH) +49-228-985800 > > > > If the original is by w...@tools.de, who is this version by? > > Or is this simply copied from some

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Conrad Meyer
On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes wrote: >> + * w...@tools.de (Wolfgang Solfrank, TooLs GmbH) +49-228-985800 > > If the original is by w...@tools.de, who is this version by? > Or is this simply copied from some other FreeBSD file? This is covered thoroughly in lines 1-10 of th

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Rodney W. Grimes
> Author: mjg > Date: Mon May 7 15:07:28 2018 > New Revision: 24 > URL: https://svnweb.freebsd.org/changeset/base/24 > > Log: > amd64: replace libkern's memset and memmove with assembly variants > > memmove is repurposed bcopy (arguments swapped, return value added) > The libkern

svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Mateusz Guzik
Author: mjg Date: Mon May 7 15:07:28 2018 New Revision: 24 URL: https://svnweb.freebsd.org/changeset/base/24 Log: amd64: replace libkern's memset and memmove with assembly variants memmove is repurposed bcopy (arguments swapped, return value added) The libkern variant is a wrappe