Re: svn commit: r333345 - head/sys/dev/e1000

2018-05-15 Thread Matthew Macy
See r333631 On Tue, May 15, 2018 at 09:18 Mark Johnston wrote: > On Tue, May 08, 2018 at 01:39:45AM +, Matt Macy wrote: > > Author: mmacy > > Date: Tue May 8 01:39:45 2018 > > New Revision: 45 > > URL: https://svnweb.freebsd.org/changeset/base/45 > > > > Log: > > Sleep rather than

Re: svn commit: r333345 - head/sys/dev/e1000

2018-05-15 Thread Mark Johnston
On Tue, May 08, 2018 at 01:39:45AM +, Matt Macy wrote: > Author: mmacy > Date: Tue May 8 01:39:45 2018 > New Revision: 45 > URL: https://svnweb.freebsd.org/changeset/base/45 > > Log: > Sleep rather than spin in e1000 when doing long running config operations. > > With r333218 i

Re: svn commit: r333345 - head/sys/dev/e1000

2018-05-08 Thread Mark Johnston
On Tue, May 08, 2018 at 04:37:52PM -0700, Matthew Macy wrote: > Nix that. The panic is incorrect, we simply don't have anything to do > in the default case. Indeed, getting rid of the panic allows my workstation to boot. > On Tue, May 8, 2018 at 4:31 PM, Matthew Macy wrote: > > Can you please tr

Re: svn commit: r333345 - head/sys/dev/e1000

2018-05-08 Thread Mark Johnston
On Tue, May 8, 2018, 19:09 Matthew Macy, wrote: > Is the e1000 driver compiled in or loaded as a module? > It's compiled in to the kernel. > On Tue, May 8, 2018 at 3:10 PM, Mark Johnston wrote: > > On Tue, May 08, 2018 at 01:39:45AM +, Matt Macy wrote: > >> Author: mmacy > >> Date: Tue Ma

Re: svn commit: r333345 - head/sys/dev/e1000

2018-05-08 Thread Matthew Macy
Nix that. The panic is incorrect, we simply don't have anything to do in the default case. On Tue, May 8, 2018 at 4:31 PM, Matthew Macy wrote: > Can you please try the attached patch? (Note that gmail may insert > carriage returns) > > -M > > On Tue, May 8, 2018 at 3:10 PM, Mark Johnston wrote:

Re: svn commit: r333345 - head/sys/dev/e1000

2018-05-08 Thread Matthew Macy
Can you please try the attached patch? (Note that gmail may insert carriage returns) -M On Tue, May 8, 2018 at 3:10 PM, Mark Johnston wrote: > On Tue, May 08, 2018 at 01:39:45AM +, Matt Macy wrote: >> Author: mmacy >> Date: Tue May 8 01:39:45 2018 >> New Revision: 45 >> URL: https://svn

Re: svn commit: r333345 - head/sys/dev/e1000

2018-05-08 Thread Matthew Macy
Is the e1000 driver compiled in or loaded as a module? -M On Tue, May 8, 2018 at 3:10 PM, Mark Johnston wrote: > On Tue, May 08, 2018 at 01:39:45AM +, Matt Macy wrote: >> Author: mmacy >> Date: Tue May 8 01:39:45 2018 >> New Revision: 45 >> URL: https://svnweb.freebsd.org/changeset/bas

Re: svn commit: r333345 - head/sys/dev/e1000

2018-05-08 Thread Mark Johnston
On Tue, May 08, 2018 at 01:39:45AM +, Matt Macy wrote: > Author: mmacy > Date: Tue May 8 01:39:45 2018 > New Revision: 45 > URL: https://svnweb.freebsd.org/changeset/base/45 > > Log: > Sleep rather than spin in e1000 when doing long running config operations. > > With r333218 i

svn commit: r333345 - head/sys/dev/e1000

2018-05-07 Thread Matt Macy
Author: mmacy Date: Tue May 8 01:39:45 2018 New Revision: 45 URL: https://svnweb.freebsd.org/changeset/base/45 Log: Sleep rather than spin in e1000 when doing long running config operations. With r333218 it is now possible for drivers to use an sx lock and thus sleep while waiti