Re: svn commit: r333844 - head/sys/kern

2018-05-19 Thread Konstantin Belousov
On Sat, May 19, 2018 at 12:22:48PM +0200, Hans Petter Selasky wrote: > On 05/19/18 06:13, Matt Macy wrote: > > va_start(ap, fmt); > > - res = make_dev_credv(0, , devsw, unit, cr, uid, gid, mode, fmt, ap); > > + DBGSET(res, make_dev_credv(0, , devsw, unit, cr, uid, gid, mode, > > fmt,

Re: svn commit: r333844 - head/sys/kern

2018-05-19 Thread Hans Petter Selasky
On 05/19/18 06:13, Matt Macy wrote: va_start(ap, fmt); - res = make_dev_credv(0, , devsw, unit, cr, uid, gid, mode, fmt, ap); + DBGSET(res, make_dev_credv(0, , devsw, unit, cr, uid, gid, mode, fmt, ap)); Is the make_dev_credv() called stubbed for non-debug builds? --HPS

svn commit: r333844 - head/sys/kern

2018-05-18 Thread Matt Macy
Author: mmacy Date: Sat May 19 04:13:20 2018 New Revision: 333844 URL: https://svnweb.freebsd.org/changeset/base/333844 Log: make_dev: avoid unused assignments on non debug builds Modified: head/sys/kern/kern_conf.c Modified: head/sys/kern/kern_conf.c