Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-21 Thread Matthew Macy
On Tue, Aug 21, 2018 at 16:52 Mark Johnston wrote: > On Tue, Aug 21, 2018 at 04:00:10PM -0700, Matthew Macy wrote: > > Yes. See r338162. Thanks. > > You missed instances of the same bug in in_mcast.c and in6_mcast.c. Thanks > > > > On Tue, Aug 21, 2018 at 2:24 PM Gleb Smirnoff > wrote: > >

Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-21 Thread Mark Johnston
On Tue, Aug 21, 2018 at 04:00:10PM -0700, Matthew Macy wrote: > Yes. See r338162. Thanks. You missed instances of the same bug in in_mcast.c and in6_mcast.c. > On Tue, Aug 21, 2018 at 2:24 PM Gleb Smirnoff wrote: > > On Wed, Aug 15, 2018 at 08:23:09PM +, Matt Macy wrote: > > M> @@ -3772,8

Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-21 Thread Matthew Macy
Yes. See r338162. Thanks. -M On Tue, Aug 21, 2018 at 2:24 PM Gleb Smirnoff wrote: > On Wed, Aug 15, 2018 at 08:23:09PM +, Matt Macy wrote: > M> @@ -3772,8 +3775,11 @@ if_delmulti_locked(struct ifnet *ifp, struct > ifmultiad > M> ll_ifma->ifma_ifp = NULL; /* XXX */

Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-21 Thread Gleb Smirnoff
On Wed, Aug 15, 2018 at 08:23:09PM +, Matt Macy wrote: M> @@ -3772,8 +3775,11 @@ if_delmulti_locked(struct ifnet *ifp, struct ifmultiad M> ll_ifma->ifma_ifp = NULL; /* XXX */ M> if (--ll_ifma->ifma_refcount == 0) { M> if (ifp !=

Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-17 Thread Matthew Macy
Sorry. I'll take a look. On Fri, Aug 17, 2018 at 05:30 Andrey V. Elsukov wrote: > On 15.08.2018 23:23, Matt Macy wrote: > > Author: mmacy > > Date: Wed Aug 15 20:23:08 2018 > > New Revision: 337866 > > URL: https://svnweb.freebsd.org/changeset/base/337866 > > > > Log: > > Fix in6_multi double

Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-17 Thread Andrey V. Elsukov
On 15.08.2018 23:23, Matt Macy wrote: > Author: mmacy > Date: Wed Aug 15 20:23:08 2018 > New Revision: 337866 > URL: https://svnweb.freebsd.org/changeset/base/337866 > > Log: > Fix in6_multi double free > > This is actually several different bugs: > - The code is not designed to handle

svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-15 Thread Matt Macy
Author: mmacy Date: Wed Aug 15 20:23:08 2018 New Revision: 337866 URL: https://svnweb.freebsd.org/changeset/base/337866 Log: Fix in6_multi double free This is actually several different bugs: - The code is not designed to handle inpcb deletion after interface deletion - add reference