Re: svn commit: r339673 - head/stand/libsa

2018-10-24 Thread Andrey V. Elsukov
On 24.10.2018 18:08, Warner Losh wrote: > > >  Note that libstand also provides crc32.c which seems to be unused. > > > > It is used by part.c, by the GPT functions. However, if we have > non-optional compile case for crc32, it is not hard to update part.c > and drop the unused

Re: svn commit: r339673 - head/stand/libsa

2018-10-24 Thread Warner Losh
On Wed, Oct 24, 2018 at 9:01 AM Konstantin Belousov wrote: > On Wed, Oct 24, 2018 at 08:33:19AM +0300, Toomas Soome wrote: > > > > > > > On 24 Oct 2018, at 02:11, Konstantin Belousov wrote: > > > > > > Author: kib > > > Date: Tue Oct 23 23:11:38 2018 > > > New Revision: 339673 > > > URL: https:/

Re: svn commit: r339673 - head/stand/libsa

2018-10-24 Thread Konstantin Belousov
On Wed, Oct 24, 2018 at 08:33:19AM +0300, Toomas Soome wrote: > > > > On 24 Oct 2018, at 02:11, Konstantin Belousov wrote: > > > > Author: kib > > Date: Tue Oct 23 23:11:38 2018 > > New Revision: 339673 > > URL: https://svnweb.freebsd.org/changeset/base/339673 > > > > Log: > > Fix stand/ buil

Re: svn commit: r339673 - head/stand/libsa

2018-10-24 Thread Warner Losh
On Wed, Oct 24, 2018 at 8:44 AM Toomas Soome wrote: > > > > On 24 Oct 2018, at 02:11, Konstantin Belousov wrote: > > > > Author: kib > > Date: Tue Oct 23 23:11:38 2018 > > New Revision: 339673 > > URL: https://svnweb.freebsd.org/changeset/base/339673 > > > > Log: > > Fix stand/ build after r339

Re: svn commit: r339673 - head/stand/libsa

2018-10-24 Thread Toomas Soome via svn-src-head
> On 24 Oct 2018, at 02:11, Konstantin Belousov wrote: > > Author: kib > Date: Tue Oct 23 23:11:38 2018 > New Revision: 339673 > URL: https://svnweb.freebsd.org/changeset/base/339673 > > Log: > Fix stand/ build after r339671. > > ffs_subr.c requires calculate_crc32c() from libkern. Unfort

svn commit: r339673 - head/stand/libsa

2018-10-23 Thread Konstantin Belousov
Author: kib Date: Tue Oct 23 23:11:38 2018 New Revision: 339673 URL: https://svnweb.freebsd.org/changeset/base/339673 Log: Fix stand/ build after r339671. ffs_subr.c requires calculate_crc32c() from libkern. Unfortunately we cannot just add libkern/crc32.c to libstand because crc32.o is