Re: svn commit: r367651 - head/usr.sbin/bhyve

2020-11-13 Thread Rebecca Cran
On 11/13/20 5:47 PM, Ravi Pokala wrote: +#define FIRMWARE_RELEASE_DATE "11/10/2020" Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and ISO-8601 demand? ;-) I wish! I'll add a comment clarifying that the specification mandates mm/dd/. -- Rebecca Cran ___

Re: svn commit: r367651 - head/usr.sbin/bhyve

2020-11-13 Thread Ravi Pokala
-Original Message- From: on behalf of Jessica Clarke Date: 2020-11-13, Friday at 16:53 To: Ravi Pokala Cc: Rebecca Cran , , , Subject: Re: svn commit: r367651 - head/usr.sbin/bhyve On 14 Nov 2020, at 00:47, Ravi Pokala wrote: > >> +#define FIRMWARE_RELEASE

Re: svn commit: r367651 - head/usr.sbin/bhyve

2020-11-13 Thread Jessica Clarke
On 14 Nov 2020, at 00:47, Ravi Pokala wrote: > >> +#define FIRMWARE_RELEASE_DATE "11/10/2020" > > Might I suggest "2020-11-10", as sorting, logic, ${DEITY}, and ISO-8601 > demand? ;-) Alas that is a "feature" of the specification: String number of the BIOS release date. The date strin

Re: svn commit: r367651 - head/usr.sbin/bhyve

2020-11-13 Thread Ravi Pokala
, Subject: svn commit: r367651 - head/usr.sbin/bhyve Author: bcran Date: Fri Nov 13 19:47:16 2020 New Revision: 367651 URL: https://svnweb.freebsd.org/changeset/base/367651 Log: bhyve: update smbiostbl.c to bump the version and release date Since lots of work has b

Re: svn commit: r367651 - head/usr.sbin/bhyve

2020-11-13 Thread Rebecca Cran
On 11/13/20 1:03 PM, Shawn Webb wrote: Style nit: shouldn't there be a tab between #define and the macro? Thanks, I'll try and remember that in future. -- Rebecca Cran ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/l

Re: svn commit: r367651 - head/usr.sbin/bhyve

2020-11-13 Thread Shawn Webb
On Fri, Nov 13, 2020 at 07:47:16PM +, Rebecca Cran wrote: > Author: bcran > Date: Fri Nov 13 19:47:16 2020 > New Revision: 367651 > URL: https://svnweb.freebsd.org/changeset/base/367651 > > Log: > bhyve: update smbiostbl.c to bump the version and release date > > Since lots of work has

svn commit: r367651 - head/usr.sbin/bhyve

2020-11-13 Thread Rebecca Cran
Author: bcran Date: Fri Nov 13 19:47:16 2020 New Revision: 367651 URL: https://svnweb.freebsd.org/changeset/base/367651 Log: bhyve: update smbiostbl.c to bump the version and release date Since lots of work has been done on bhyve since 2014, increase the version to 13.0 to match 13-CURREN