svn commit: r304553 - stable/10/lib/libc/tests/stdlib

2016-08-20 Thread Garrett Cooper
Author: ngie Date: Sun Aug 21 05:08:37 2016 New Revision: 304553 URL: https://svnweb.freebsd.org/changeset/base/304553 Log: Unbreak the build when MK_TESTS != no after r304527 - src.opts.mk should be bsd.own.mk on ^/stable/10 - LIBADD should be DPADD/LDADD on ^/stable/10 Pointyhat to

svn commit: r304210 - stable/10/usr.bin/getconf

2016-08-16 Thread Garrett Cooper
Author: ngie Date: Tue Aug 16 08:30:28 2016 New Revision: 304210 URL: https://svnweb.freebsd.org/changeset/base/304210 Log: MFstable/11 r304208: MFC r303830: Remove vestigal references to __alpha__ Replace alpha reference in getconf(1) with amd64 [*] PR: 211300 [*]

svn commit: r303694 - stable/10/tools/build/mk

2016-08-02 Thread Garrett Cooper
Author: ngie Date: Wed Aug 3 01:25:44 2016 New Revision: 303694 URL: https://svnweb.freebsd.org/changeset/base/303694 Log: MFC r302330: Remove ftp(1) related files when MK_FTP == no Modified: stable/10/tools/build/mk/OptionalObsoleteFiles.inc Directory Properties: stable/10/ (props

svn commit: r303692 - stable/10/sys/rpc

2016-08-02 Thread Garrett Cooper
Author: ngie Date: Wed Aug 3 01:19:10 2016 New Revision: 303692 URL: https://svnweb.freebsd.org/changeset/base/303692 Log: MFstable/11 r303691: MFC r302550,r302551,r302552,r302553: r302550: Deobfuscate cleanup path in clnt_dg_create(..) Similar to r300836 and r301800, cl and

svn commit: r303609 - stable/10/sys/conf

2016-08-01 Thread Garrett Cooper
Author: ngie Date: Mon Aug 1 06:59:35 2016 New Revision: 303609 URL: https://svnweb.freebsd.org/changeset/base/303609 Log: MFC r288071: - arm64 change was omitted due to lack of architecture support - ia64 change was added as the architecture was removed from ^/head Sponsored by: EM

svn commit: r302705 - stable/10/usr.sbin/bhyve

2016-07-12 Thread Garrett Cooper
Author: ngie Date: Wed Jul 13 06:09:34 2016 New Revision: 302705 URL: https://svnweb.freebsd.org/changeset/base/302705 Log: MFC r302362,r302363,r302364,r302365,r302373: r302362: Fix gcc warnings - Remove -Wunused-but-set-variable (newcpu) - Always return VMEXIT_CONTINUE as the c

svn commit: r302583 - stable/10/usr.bin/lastcomm/tests

2016-07-11 Thread Garrett Cooper
Author: ngie Date: Mon Jul 11 17:31:30 2016 New Revision: 302583 URL: https://svnweb.freebsd.org/changeset/base/302583 Log: MFC r302327: Fix .../usr.bin/lastcomm/legacy_test:main on i386 The time in the output files was ahead by 3 hours on i386. Fix the incorrect offset. PR: 210

svn commit: r302582 - stable/10/usr.bin/lastcomm/tests

2016-07-11 Thread Garrett Cooper
Author: ngie Date: Mon Jul 11 17:30:20 2016 New Revision: 302582 URL: https://svnweb.freebsd.org/changeset/base/302582 Log: MFC r302326: Output the diffs to standard error when comparing the expected vs the obtained output from lastcomm instead of just printing out a summary, e.g. "they

svn commit: r302455 - stable/10/usr.sbin/rpc.lockd

2016-07-08 Thread Garrett Cooper
Author: ngie Date: Fri Jul 8 20:50:44 2016 New Revision: 302455 URL: https://svnweb.freebsd.org/changeset/base/302455 Log: MFC r301871: Add missing break in lock_partialfilelock(..) with NFS_RESERR This will help ensure that the right error is trickled up when the function is called

svn commit: r302453 - stable/10/usr.sbin/rpcbind

2016-07-08 Thread Garrett Cooper
Author: ngie Date: Fri Jul 8 20:39:37 2016 New Revision: 302453 URL: https://svnweb.freebsd.org/changeset/base/302453 Log: MFC r301605: Bounds check rpcbs_rmtcall(..) to ensure rtype is less than RPCBVERS_STAT Not returning if rtype == RPCBVERS_STAT will cause us to overrun the inf a

svn commit: r302451 - stable/10/sys/rpc

2016-07-08 Thread Garrett Cooper
Author: ngie Date: Fri Jul 8 20:30:20 2016 New Revision: 302451 URL: https://svnweb.freebsd.org/changeset/base/302451 Log: MFC r301800: Deobfuscate cleanup path in clnt_bck_create(..) Similar to r300836, cl and ct will always be non-NULL as they're allocated using the mem_alloc rout

svn commit: r302447 - stable/10/contrib/netbsd-tests/lib/libc/string

2016-07-08 Thread Garrett Cooper
Author: ngie Date: Fri Jul 8 19:19:30 2016 New Revision: 302447 URL: https://svnweb.freebsd.org/changeset/base/302447 Log: MFC r301749: Add debug output to aid in determining why `goodResult` != `result` PR: 210619 (for diagnosis) Modified: stable/10/contrib/netbsd-tests/lib/libc/s

svn commit: r302444 - stable/10/lib/libc/net

2016-07-08 Thread Garrett Cooper
Author: ngie Date: Fri Jul 8 19:13:18 2016 New Revision: 302444 URL: https://svnweb.freebsd.org/changeset/base/302444 Log: MFC r301708: Revert r301707 getnetent_p doesn't return NULL like getnetent does. coccinelle got confused and I didn't verify that it worked before committing t

svn commit: r302442 - stable/10/lib/libc/net

2016-07-08 Thread Garrett Cooper
Author: ngie Date: Fri Jul 8 19:04:51 2016 New Revision: 302442 URL: https://svnweb.freebsd.org/changeset/base/302442 Log: MFC r301707: Use NULL instead of `0` in _ht_getnetbyname(..) - getnetent returns NULL on completion/error. - .h_aliases is NULL terminated. Modified: stable/

svn commit: r301836 - stable/10/contrib/top

2016-06-11 Thread Garrett Cooper
Author: ngie Date: Sun Jun 12 05:57:42 2016 New Revision: 301836 URL: https://svnweb.freebsd.org/changeset/base/301836 Log: MFC r300395: Silence top(1) compiler warnings The contrib/top code is no longer maintained upstream (last pulled 16 years ago). The K&R-style followed by the co

svn commit: r301833 - in stable/10/sys: sys vm

2016-06-11 Thread Garrett Cooper
Author: ngie Date: Sat Jun 11 11:28:29 2016 New Revision: 301833 URL: https://svnweb.freebsd.org/changeset/base/301833 Log: Redo MFC r300220,r300223: Differential Revision: https://reviews.freebsd.org/D6803 Reviewed by: alc, kib Sponsored by: EMC / Isilon Storage Division r300220 (

svn commit: r301832 - stable/10

2016-06-11 Thread Garrett Cooper
Author: ngie Date: Sat Jun 11 11:25:49 2016 New Revision: 301832 URL: https://svnweb.freebsd.org/changeset/base/301832 Log: Revert r301831 -- I forgot to add the diff from Phabricator Pointyhat to: ngie (never commit without svn status half asleep) Modified: Directory Properties: stable/

svn commit: r301831 - stable/10

2016-06-11 Thread Garrett Cooper
Author: ngie Date: Sat Jun 11 11:24:30 2016 New Revision: 301831 URL: https://svnweb.freebsd.org/changeset/base/301831 Log: MFC r300220,r300223: Differential Revision: https://reviews.freebsd.org/D6803 Reviewed by: alc, kib Sponsored by: EMC / Isilon Storage Division r300220 (by ce

svn commit: r301820 - stable/10/lib/libc/rpc

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Sat Jun 11 01:37:59 2016 New Revision: 301820 URL: https://svnweb.freebsd.org/changeset/base/301820 Log: MFC r301704: Test for strchr(3) returning NULL, not 0 Modified: stable/10/lib/libc/rpc/getnetpath.c Directory Properties: stable/10/ (props changed) Modified:

svn commit: r301818 - stable/10/etc/defaults

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Sat Jun 11 01:34:41 2016 New Revision: 301818 URL: https://svnweb.freebsd.org/changeset/base/301818 Log: MFC r301683: Fix typo with description for $ipv6_cpe_wanif (upstram -> upstream) PR: 210146 Modified: stable/10/etc/defaults/rc.conf Directory Properties: st

svn commit: r301813 - stable/10

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 18:47:11 2016 New Revision: 301813 URL: https://svnweb.freebsd.org/changeset/base/301813 Log: Record mergeinfo for all complete commits done in the ioat(4) merge in r300661 This will make it easier for someone to determine what's missing when running `svn m

svn commit: r301812 - stable/10/sys/dev/ioat

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 18:40:03 2016 New Revision: 301812 URL: https://svnweb.freebsd.org/changeset/base/301812 Log: MFC r301296,r301297,r301300: r301296 (by cem): ioat(4): Make channel indices unsigned r301297 (by cem): ioat(4): Export the number of available channels

svn commit: r301811 - stable/10/sys/dev/ntb/ntb_hw

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 18:34:31 2016 New Revision: 301811 URL: https://svnweb.freebsd.org/changeset/base/301811 Log: MFC r295618,r300100,r300531: r295618 (by cem): NTB: workaround for high traffic hardware hang This patch comes from Dave Jiang's Linux tree, davejiang/ntb.

svn commit: r301809 - stable/10/usr.sbin/rtadvd

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 18:21:05 2016 New Revision: 301809 URL: https://svnweb.freebsd.org/changeset/base/301809 Log: MFC r299513,r299515: r299513 (by cem): rtadvd(8): Don't use-after-free This whole block of code as committed fully formed in r224144. I'm not really sure

svn commit: r301808 - stable/10/lib/libc/tests/stdio

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 18:13:41 2016 New Revision: 301808 URL: https://svnweb.freebsd.org/changeset/base/301808 Log: MFC r299511: r299511 (by cem): print_positional_test: Fix misuse of wchar APIs These APIs take unit length, not byte length parameters. CIDs: 13385

svn commit: r301806 - stable/10/lib/libmp

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 18:10:32 2016 New Revision: 301806 URL: https://svnweb.freebsd.org/changeset/base/301806 Log: MFC r299510: r299510 (by cem): libmp: Fix trivial buffer overrun fgetln yields a non-NUL-terminated buffer and its length. This routine attempted to NUL-term

svn commit: r301805 - stable/10/tests/sys/kern

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 18:07:35 2016 New Revision: 301805 URL: https://svnweb.freebsd.org/changeset/base/301805 Log: MFC r299508: r299508 (by cem): kern_descrip_test: Fix trivial buffer overrun with readlink(2) CID: 1229965, 1229972 Modified: stable/10/tests/sys/ke

svn commit: r301803 - stable/10/usr.sbin/rtadvd

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 18:02:51 2016 New Revision: 301803 URL: https://svnweb.freebsd.org/changeset/base/301803 Log: MFC r299507: r299507 (by cem): rtadvd(8): Fix a typo in full msg receive logic Check against the size of the struct, not the pointer. Previously, a message w

svn commit: r301801 - stable/10/sys/rpc

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 17:57:50 2016 New Revision: 301801 URL: https://svnweb.freebsd.org/changeset/base/301801 Log: MFC r300836: Quell false positives in svc_vc_create and svc_vc_create_conn with cd and xprt Both cd and xprt will be non-NULL after their respective malloc(9) wra

svn commit: r301799 - stable/10/sys/dev/sound/pci/hda

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 15:47:20 2016 New Revision: 301799 URL: https://svnweb.freebsd.org/changeset/base/301799 Log: MFC r299503,r299504: r299503 (by cem): snd_hda(4): Don't pass bogus sizeof()s to unused sysctl arg2 parameter None of the sysctl handlers in hdaa use the arg

svn commit: r301798 - stable/10/lib/libc/tests/nss

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 15:42:17 2016 New Revision: 301798 URL: https://svnweb.freebsd.org/changeset/base/301798 Log: MFC r299502: r299502 (by cem): nss/gethostby_test: fix broken vector iteration of gethostbyaddr h_aliases h_aliases is a NULL-terminated rather than fixed-lengt

svn commit: r301793 - stable/10/contrib/atf/atf-c/detail

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 14:51:11 2016 New Revision: 301793 URL: https://svnweb.freebsd.org/changeset/base/301793 Log: MFC r299496: r299496 (by cem): atf map: Fix double-free in low memory error path If atf_list_append(, X, ) fails, X is freed. Don't free it again. CID:

svn commit: r301792 - stable/10/crypto/heimdal/lib/krb5

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 14:48:10 2016 New Revision: 301792 URL: https://svnweb.freebsd.org/changeset/base/301792 Log: MFC r299495: r299495 (by cem): libkrb5: Fix potential double-free If krb5_make_principal fails, tmp_creds.server may remain a pointer to freed memory and then

svn commit: r301791 - stable/10/sys/kern

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 14:45:20 2016 New Revision: 301791 URL: https://svnweb.freebsd.org/changeset/base/301791 Log: MFC r299494: r299494 (by cem): subr_vmem: Fix double-free in error case of vmem_create If vmem_init() fails, 'vm' is already destroyed and freed. Don't free it

svn commit: r301789 - stable/10/usr.sbin/route6d

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 14:40:41 2016 New Revision: 301789 URL: https://svnweb.freebsd.org/changeset/base/301789 Log: MFC r299491: r299491 (by cem): route6d(8): Fix potential double-free In the case that the subsequent sysctl(3) call failed, 'buf' could be free(3)ed repeated

svn commit: r301788 - stable/10/sbin/camcontrol

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 14:33:21 2016 New Revision: 301788 URL: https://svnweb.freebsd.org/changeset/base/301788 Log: MFC r299490: r299490 (by cem): camcontrol(8): Fix another trivial double-free CID: 1331222 Modified: stable/10/sbin/camcontrol/fwdownload.c Director

svn commit: r301786 - stable/10/sbin/camcontrol

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 14:31:03 2016 New Revision: 301786 URL: https://svnweb.freebsd.org/changeset/base/301786 Log: MFC r299489: r299489 (by cem): camcontrol(8): Fix trival double-free CID: 1331223 Modified: stable/10/sbin/camcontrol/camcontrol.c Directory Propert

svn commit: r301784 - stable/10/usr.sbin/makefs/ffs

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 14:13:24 2016 New Revision: 301784 URL: https://svnweb.freebsd.org/changeset/base/301784 Log: MFC r299461: r299461 (by cem): ffs_bswap: Copy one UFS dinode member at a time No functional change. CIDs: 974635, 974636, 977396, 977397, 977398,

svn commit: r301782 - stable/10/sbin/fsck_ffs

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 14:08:41 2016 New Revision: 301782 URL: https://svnweb.freebsd.org/changeset/base/301782 Log: MFC r299460: r299460 (by cem): fsck_ffs: Don't overrun mount device buffer Maybe this case is impossible. Either way, when attempting to "/dev/"-prefix a no

svn commit: r301780 - stable/10/sys/netipsec

2016-06-10 Thread Garrett Cooper
Author: ngie Date: Fri Jun 10 13:57:56 2016 New Revision: 301780 URL: https://svnweb.freebsd.org/changeset/base/301780 Log: MFC r299387: r299387 (by cem): netipsec: Fix minor style nit Coverity points out that 'continue' is equivalent to 'break' in a do {} while(false) loop. C

svn commit: r301695 - stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 20:47:25 2016 New Revision: 301695 URL: https://svnweb.freebsd.org/changeset/base/301695 Log: MFC r300870,r300884: r300870: Unbreak the zfs(4) build vm/vm_pageout.h grew a dependency on the bool typedef in r300865 arc.c didn't include sys/types.h

svn commit: r301687 - stable/10/lib/libc/rpc

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:46:10 2016 New Revision: 301687 URL: https://svnweb.freebsd.org/changeset/base/301687 Log: MFC r300624: Fix up r300385 I accidentally glossed over the fact that tmp is manipulated via strchr, so if we tried to free `tmp` after r300385, it would have c

svn commit: r301684 - stable/10/lib/libc/rpc

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:41:49 2016 New Revision: 301684 URL: https://svnweb.freebsd.org/changeset/base/301684 Log: MFC r300385: Don't leak `tmp` if `p->nc_lookups` can't be malloced Modified: stable/10/lib/libc/rpc/getnetconfig.c Directory Properties: stable/10/ (props chang

svn commit: r301682 - stable/10/lib/libc/rpc

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:27:44 2016 New Revision: 301682 URL: https://svnweb.freebsd.org/changeset/base/301682 Log: MFC r300386: Don't leak `handle` if svc_tp_create(..) succeeds and allocating a new struct xlist object fails CID: 978277 Modified: stable/10/lib/libc/rpc/sv

svn commit: r301680 - stable/10/sys/rpc

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:22:54 2016 New Revision: 301680 URL: https://svnweb.freebsd.org/changeset/base/301680 Log: MFC r300625: Remove unnecessary memset(.., 0, ..)'s The mem_alloc macro calls calloc (userspace) / malloc(.., M_WAITOK|M_ZERO) under the covers, so zeroing out

svn commit: r301678 - stable/10/tools/tools/ioat

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:21:25 2016 New Revision: 301678 URL: https://svnweb.freebsd.org/changeset/base/301678 Log: MFC r300861,r300862: r300861: - Sort make variables - Use SRCTOP instead of ad hoc definition for it r300862: Install ioatcontrol to /usr/bin by defau

svn commit: r301677 - stable/10/tools/tools/ioat

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:19:34 2016 New Revision: 301677 URL: https://svnweb.freebsd.org/changeset/base/301677 Log: MFC r300856,r300857,r300858,r300874: r300856: Initialize `t` with memset(.., 0, ..) This will help ensure that we're not using random garbage on the stack by

svn commit: r301675 - stable/10/contrib/top

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:15:51 2016 New Revision: 301675 URL: https://svnweb.freebsd.org/changeset/base/301675 Log: MFC r300714: The readme provides a high-level overview of how to upgrade top(1). Reviewed By: ngie Added: stable/10/contrib/top/FREEBSD-upgrade - copied u

svn commit: r301673 - stable/10/lib/libbsnmp

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:14:06 2016 New Revision: 301673 URL: https://svnweb.freebsd.org/changeset/base/301673 Log: MFC r299699: Remove NO_WERROR from libbsnmp/Makefile.inc This has been compiling without warnings with clang/gcc for a while now Tested with: clang 3.8.0, gc

svn commit: r301671 - stable/10/usr.sbin/bsnmpd/modules/snmp_mibII

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:08:06 2016 New Revision: 301671 URL: https://svnweb.freebsd.org/changeset/base/301671 Log: MFC r299815: Remove NO_WERROR.clang from this Makefile This compiles with clang without warnings Modified: stable/10/usr.sbin/bsnmpd/modules/snmp_mibII/Makefil

svn commit: r301669 - stable/10/usr.sbin/bsnmpd/tools

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 18:05:52 2016 New Revision: 301669 URL: https://svnweb.freebsd.org/changeset/base/301669 Log: MFC r299806: Bump WARNS to 6 Modified: stable/10/usr.sbin/bsnmpd/tools/Makefile.inc Directory Properties: stable/10/ (props changed) Modified: stable/10/usr.sb

svn commit: r301667 - stable/10/contrib/bsnmp/snmpd

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:59:21 2016 New Revision: 301667 URL: https://svnweb.freebsd.org/changeset/base/301667 Log: MFC r299834: Fix .Dd Today is the 14th, not the 10th of May Modified: stable/10/contrib/bsnmp/snmpd/bsnmpd.1 Directory Properties: stable/10/ (props change

svn commit: r301663 - in stable/10/contrib/bsnmp: snmp_mibII snmpd

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:49:03 2016 New Revision: 301663 URL: https://svnweb.freebsd.org/changeset/base/301663 Log: MFC r294507,r294567,r299466: r294507 (by harti): Fill the ifAlias leaf of the ifXTable with the interface description if there is one available and it fits into

svn commit: r301661 - in stable/10/contrib/bsnmp: lib snmp_mibII snmp_target

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:43:04 2016 New Revision: 301661 URL: https://svnweb.freebsd.org/changeset/base/301661 Log: MFC r256678,r256680,r260986,r272878,r286402: r256678 (by syrinx): Fix SNMP Error response PDUs and properly encode them when using v3 auth/encryption. r2566

svn commit: r301657 - stable/10/usr.sbin/bsnmpd/tools/libbsnmptools

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:34:37 2016 New Revision: 301657 URL: https://svnweb.freebsd.org/changeset/base/301657 Log: MFC r299701: Move _bsnmptools_debug extern from bsnmpmap.c to bsnmptools.h It was used in bsnmpmap.c but was stored in bsnmptools.c; moving the extern to the he

svn commit: r301656 - stable/10/usr.sbin/bsnmpd/tools/libbsnmptools

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:32:41 2016 New Revision: 301656 URL: https://svnweb.freebsd.org/changeset/base/301656 Log: MFC r299778: Use a consistent errno save/restore pattern before running strtoul - Save errno - Set errno to 0 - Call strtoul - Test errno (optional, but man

svn commit: r301655 - stable/10/usr.sbin/bsnmpd/tools/libbsnmptools

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:30:29 2016 New Revision: 301655 URL: https://svnweb.freebsd.org/changeset/base/301655 Log: MFC r299766: Fix logically dead code pointed out by clang/Coverity parse_context, parse_user_security: test for validity of results from parse_ascii(..) with by

svn commit: r301653 - stable/10/usr.sbin/bsnmpd/tools/libbsnmptools

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:27:38 2016 New Revision: 301653 URL: https://svnweb.freebsd.org/changeset/base/301653 Log: MFC r299810: Correct function names that failed in error messages It should be calloc/strdup, not malloc Modified: stable/10/usr.sbin/bsnmpd/tools/libbsnmptool

svn commit: r301648 - stable/10/usr.sbin/rpcbind

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:13:28 2016 New Revision: 301648 URL: https://svnweb.freebsd.org/changeset/base/301648 Log: MFC r300947: Staticize variables only used in rpcbind.c This is some low hanging fruit necessary for making this WARNS?= 6 clean Modified: stable/10/usr.sbin/r

svn commit: r301646 - stable/10/usr.sbin/rpcbind

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:11:42 2016 New Revision: 301646 URL: https://svnweb.freebsd.org/changeset/base/301646 Log: MFC r300945: Remove unnecessary caller_uaddr != NULL test before calling free on it Modified: stable/10/usr.sbin/rpcbind/util.c Directory Properties: stable/10/

svn commit: r301644 - stable/10/usr.sbin/rpcbind

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 17:09:47 2016 New Revision: 301644 URL: https://svnweb.freebsd.org/changeset/base/301644 Log: MFC r300942: Remove a useless if (x != NULL) check before calling free on allocated_uaddr Modified: stable/10/usr.sbin/rpcbind/check_bound.c Directory Properties:

svn commit: r301636 - stable/10/usr.sbin/rpcbind

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 15:41:39 2016 New Revision: 301636 URL: https://svnweb.freebsd.org/changeset/base/301636 Log: MFC r300867,r300932,r300934,r300941,r300972,r300973: r300867: Only expose `hint_uaddr` in the ND_DEBUG case This fixes a -Wunused-but-set-variable warning wi

svn commit: r301629 - stable/10/lib/libc/rpc

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 14:18:47 2016 New Revision: 301629 URL: https://svnweb.freebsd.org/changeset/base/301629 Log: MFC r300387,r300388,r300389: r300387: getnetid(..): consistently fclose fd at the end of the function This mutes a false positive with cppcheck, but also hel

svn commit: r301627 - stable/10/bin/ls/tests

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 14:07:43 2016 New Revision: 301627 URL: https://svnweb.freebsd.org/changeset/base/301627 Log: MFC r300939: Use require.progs with bc instead of require.files with /usr/bin/bc This will make things more flexible if the program path changes in the future,

svn commit: r301626 - stable/10/tools/build/mk

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 14:06:34 2016 New Revision: 301626 URL: https://svnweb.freebsd.org/changeset/base/301626 Log: MFC r300938: Remove the sa(8) tests if MK_ACCT == no when "make delete-old" is run sa(8) is conditionally installed based on MK_ACCT != no today Modified: stab

svn commit: r301625 - stable/10/tools/build/mk

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 14:05:08 2016 New Revision: 301625 URL: https://svnweb.freebsd.org/changeset/base/301625 Log: MFC r300937: Remove the etcupdate tests if MK_RCS == no when "make delete-old" is run etcupdate is conditionally installed based on MK_RCS != no today Modified:

svn commit: r301623 - stable/10/tools/build/mk

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 14:01:42 2016 New Revision: 301623 URL: https://svnweb.freebsd.org/changeset/base/301623 Log: MFC r300936: Remove the calendar tests if MK_CALENDAR == no when "make delete-old" is run Modified: stable/10/tools/build/mk/OptionalObsoleteFiles.inc Directory P

svn commit: r301622 - stable/10/lib/libc/rpc

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 13:58:47 2016 New Revision: 301622 URL: https://svnweb.freebsd.org/changeset/base/301622 Log: MFC r300620,r300621: r300620: Use reallocf instead of malloc to fix leak with outbuf_pmap The previous code overwrote outbuf_pmap's memory with malloc once p

svn commit: r301619 - stable/10/usr.sbin/rpc.yppasswdd

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 13:49:59 2016 New Revision: 301619 URL: https://svnweb.freebsd.org/changeset/base/301619 Log: MFC r300430: Wrap EXPAND(..) macro with a do-while(0) loop and put a single statement on each line As a positive side-effect, this eliminates the double semicolo

svn commit: r301617 - stable/10/usr.bin/kdump

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 13:44:01 2016 New Revision: 301617 URL: https://svnweb.freebsd.org/changeset/base/301617 Log: MFC r300428: Fix humanized decoding of struct stat with respect to .st_mtim st_mtim was being incorrectly described as "stime=", not "mtime=". This was introduc

svn commit: r301615 - stable/10/etc/rc.d

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 13:40:07 2016 New Revision: 301615 URL: https://svnweb.freebsd.org/changeset/base/301615 Log: MFC r299844,r300931: r299844: Make hostid_save depend on hostid r300931: Make netif REQUIRE hostid As noted in the PR, if etc/rc.d/zvol is removed,

svn commit: r301613 - stable/10/etc/rc.d

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 13:34:52 2016 New Revision: 301613 URL: https://svnweb.freebsd.org/changeset/base/301613 Log: MFC r299843: Fix broken dependency with routed when MK_ROUTED != no Remove routed as a requirement in NETWORKING, and put it in routed as a BEFORE requirement i

svn commit: r301612 - in stable/10: etc/rc.d tools/build/mk

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 13:32:00 2016 New Revision: 301612 URL: https://svnweb.freebsd.org/changeset/base/301612 Log: MFC r299839,r299840,r299841: r299839: Make FILESYSTEMS, dumpon, and var not depend on zfs and zvol Make zfs and zvol come before all of the items that depend

svn commit: r301610 - stable/10/contrib/bsnmp/snmpd

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 13:24:42 2016 New Revision: 301610 URL: https://svnweb.freebsd.org/changeset/base/301610 Log: MFC r299833: Fix fully canonicalized example for `myvariable.27...` `6` doesn't occur in the OID; it was spurious Bump .Dd for the change Modified: stable

svn commit: r301608 - stable/10/sys/cddl/boot/zfs

2016-06-08 Thread Garrett Cooper
Author: ngie Date: Wed Jun 8 13:21:17 2016 New Revision: 301608 URL: https://svnweb.freebsd.org/changeset/base/301608 Log: MFC r299657: Include arpa/inet.h to get the htonl(3) definition Modified: stable/10/sys/cddl/boot/zfs/lz4.c Directory Properties: stable/10/ (props changed) Mo

svn commit: r300561 - in stable/10: contrib/bsnmp/snmp_usm contrib/bsnmp/snmpd usr.sbin/bsnmpd/bsnmpd

2016-05-23 Thread Garrett Cooper
Author: ngie Date: Tue May 24 04:49:58 2016 New Revision: 300561 URL: https://svnweb.freebsd.org/changeset/base/300561 Log: MFC r299465,r299807,r299808,r299817,r299831,r299832,r300167: r299465 (by cem): bsnmp: Don't overrun privkey buffer by copying wrong size The 'priv_key' array

svn commit: r300559 - in stable/10/usr.sbin/bsnmpd/tools: bsnmptools libbsnmptools

2016-05-23 Thread Garrett Cooper
Author: ngie Date: Tue May 24 04:23:58 2016 New Revision: 300559 URL: https://svnweb.freebsd.org/changeset/base/300559 Log: MFC r299764,r299765,r299767,r299769,r299770,r299774,r299802,r299803,r299805,r299814: r299764: Use the size of the destination buffer, not the source buffer.

svn commit: r300475 - stable/10/usr.sbin/bsnmpd/tools/libbsnmptools

2016-05-22 Thread Garrett Cooper
Author: ngie Date: Mon May 23 06:01:04 2016 New Revision: 300475 URL: https://svnweb.freebsd.org/changeset/base/300475 Log: MFC r299710,r299711,r299763,r299783,r299811: r299710: Staticize global variables only used in bsnmpimport.c to fix -Wmissing-variable-declarations warnings

svn commit: r300471 - stable/10/usr.sbin/bsnmpd/tools/libbsnmptools

2016-05-22 Thread Garrett Cooper
Author: ngie Date: Mon May 23 05:41:53 2016 New Revision: 300471 URL: https://svnweb.freebsd.org/changeset/base/300471 Log: MFC r299712,r299759,r299760,r299761,r299762: r299712: Fix some trivial clang/gcc warnings in bsnmptc.c - By definition, `enum snmp_tc` can't be false (the im

svn commit: r300464 - stable/10/sys/boot/i386/zfsboot

2016-05-22 Thread Garrett Cooper
Author: ngie Date: Mon May 23 05:28:02 2016 New Revision: 300464 URL: https://svnweb.freebsd.org/changeset/base/300464 Log: MFC r299659: Remove unused const variable Modified: stable/10/sys/boot/i386/zfsboot/zfsboot.c Directory Properties: stable/10/ (props changed) Modified: stable

svn commit: r300460 - stable/10/sys/boot/i386/common

2016-05-22 Thread Garrett Cooper
Author: ngie Date: Mon May 23 05:23:53 2016 New Revision: 300460 URL: https://svnweb.freebsd.org/changeset/base/300460 Log: MFC r299655: Add missing prototype for getchar(..) Modified: stable/10/sys/boot/i386/common/cons.h Directory Properties: stable/10/ (props changed) Modified: s

svn commit: r300454 - stable/10/lib/libc/tests/nss

2016-05-22 Thread Garrett Cooper
Author: ngie Date: Mon May 23 05:11:31 2016 New Revision: 300454 URL: https://svnweb.freebsd.org/changeset/base/300454 Log: MFC r299654: Read the contents of the snapshot files properly - Use fgetln instead of fgets; localize complexity related to fgetln(3) inside the loop. - Ski

svn commit: r299836 - stable/10/share/mk

2016-05-14 Thread Garrett Cooper
Author: ngie Date: Sun May 15 03:53:06 2016 New Revision: 299836 URL: https://svnweb.freebsd.org/changeset/base/299836 Log: MFC r298864: Allow FILESGROUPS to be specified more than once by pruning out duplicates Modified: stable/10/share/mk/bsd.files.mk Directory Properties: stable/10/

svn commit: r299651 - stable/10/lib/libkvm

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 09:52:39 2016 New Revision: 299651 URL: https://svnweb.freebsd.org/changeset/base/299651 Log: MFC r298839: Fix memory allocation edgecases in kvm_argv(..) - Don't leak nbufp on realloc failure in kvm_argv - Catch malloc errors with bufp - Set buflen la

svn commit: r299649 - stable/10/lib/libkvm

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 09:49:52 2016 New Revision: 299649 URL: https://svnweb.freebsd.org/changeset/base/299649 Log: MFC r298842: Don't leak PML4 in _amd64_initvtop(..) if kvm_read2(..) fails CID: 1341474 Modified: stable/10/lib/libkvm/kvm_amd64.c Directory Properties: stab

svn commit: r299648 - stable/10/etc/rc.d

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 09:46:23 2016 New Revision: 299648 URL: https://svnweb.freebsd.org/changeset/base/299648 Log: MFC r298844: Make SERVERS REQUIRE clean when MK_KERBEROS==no Make kdc run BEFORE SERVERS instead of being REQUIREd by SERVERS, so systems that pedantically chec

svn commit: r299643 - in stable/10: share/man/man8 tools/build/mk

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 09:31:40 2016 New Revision: 299643 URL: https://svnweb.freebsd.org/changeset/base/299643 Log: MFC r299162,r299163: r299162: Only install NIS section 8 manpages if MK_NIS != no r299163: Fix r299162 share/man/man8/Makefile: - Add src.opts.mk

svn commit: r299640 - stable/10/sys/ufs/ufs

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 09:18:46 2016 New Revision: 299640 URL: https://svnweb.freebsd.org/changeset/base/299640 Log: MFC r298463: Add FEATURE knob for testing for UFS extended attribute kernel support Support can be verified via `feature_present("ufs_extattr")`, etc. Relnot

svn commit: r299638 - stable/10/contrib/bsnmp/snmp_mibII

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 09:14:43 2016 New Revision: 299638 URL: https://svnweb.freebsd.org/changeset/base/299638 Log: MFC r298462: Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning This will also now detect error conditions with value->var.subs[sub - 1]

svn commit: r299635 - stable/10/sys/dev/aacraid

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 09:06:52 2016 New Revision: 299635 URL: https://svnweb.freebsd.org/changeset/base/299635 Log: MFC r298665: r298665 (by cem): aacraid(4): Fix some mostly trivial buffer overruns strcpy(3) emits a trailing nul byte, trampling fields after the intended de

svn commit: r299634 - stable/10/sys/dev/ciss

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 09:05:29 2016 New Revision: 299634 URL: https://svnweb.freebsd.org/changeset/base/299634 Log: MFC r298670: r298670 (by cem): ciss(4): Fix overrun of array The softc member 'ciss_logical' is an array of 'ciss_max_logical_bus' members. Most of the time i

svn commit: r299632 - stable/10/sys/dev/sound/midi

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 09:01:20 2016 New Revision: 299632 URL: https://svnweb.freebsd.org/changeset/base/299632 Log: MFC r298339: r298339 (by cem): sound(4): Don't use-after-free in midi module unload Also, use ANSI function parameter definitions (void) while here. CID:

svn commit: r299630 - stable/10/sys/dev/sym

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 08:58:49 2016 New Revision: 299630 URL: https://svnweb.freebsd.org/changeset/base/299630 Log: MFC r298340: r298340 (by cem): sym(4): Don't double-free 'sim' in failure case CID: 1006106 Modified: stable/10/sys/dev/sym/sym_hipd.c Directory Pro

svn commit: r299629 - stable/10/sys/geom/part

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 08:54:08 2016 New Revision: 299629 URL: https://svnweb.freebsd.org/changeset/base/299629 Log: MFC r298671,r298672: r298671 (by cem): g_part_bsd64: Check for valid on-disk npartitions value This value is u32 on disk, but assigned to an int in memory.

svn commit: r299627 - stable/10/sys/netipsec

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 08:49:29 2016 New Revision: 299627 URL: https://svnweb.freebsd.org/changeset/base/299627 Log: MFC r298676: r298676 (by cem): netipsec: Don't leak memory when deep copy fails CID: 1331693 Modified: stable/10/sys/netipsec/ipsec.c Directory Prop

svn commit: r299625 - stable/10/sys/kern

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 08:44:59 2016 New Revision: 299625 URL: https://svnweb.freebsd.org/changeset/base/299625 Log: MFC r298677: r298677 (by cem): subr_mbpool: Don't free bogus pointer in error paths An mbpool is allocated with a contiguous array of mbpages. Freeing an ind

svn commit: r299623 - stable/10/sys/dev/pty

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 08:41:09 2016 New Revision: 299623 URL: https://svnweb.freebsd.org/changeset/base/299623 Log: MFC r298337: r298337 (by cem): pty(4): Use strlcpy to guarantee destination buffer isn't overrun The devtoname() name is strcpyed into a small stack buffer. Su

svn commit: r299622 - stable/10/sys/dev/drm2

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 08:39:33 2016 New Revision: 299622 URL: https://svnweb.freebsd.org/changeset/base/299622 Log: MFC r298334: r298334 (by cem): drm2(4): Fix double-free in low-memory error path Reallocf frees 'block'; don't attempt to free it again. CID: 1091

svn commit: r299621 - stable/10/sys/dev/iscsi_initiator

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 08:36:33 2016 New Revision: 299621 URL: https://svnweb.freebsd.org/changeset/base/299621 Log: MFC r298669: r298669 (by cem): iscsi_initiator(4): Fix use-after-free, double-free ism_stop() already destroys and frees 'sp', including a call to ic_destroy().

svn commit: r299619 - stable/10/sys/rpc/rpcsec_gss

2016-05-13 Thread Garrett Cooper
Author: ngie Date: Fri May 13 08:30:26 2016 New Revision: 299619 URL: https://svnweb.freebsd.org/changeset/base/299619 Log: MFC r298336: r298336 (by cem): kgssapi(4): Fix string overrun in Kerberos principal construction 'buf.value' was previously treated as a nul-terminated string,

  1   2   3   4   5   >