Re: [Swan-dev] tests failing due to retransmissions

2017-10-12 Thread Paul Wouters
On Tue, 10 Oct 2017, Antony Antony wrote: Another line that show up in several (20+ output files) IKEv1 tests as diff is: "discarding duplicate packet; already STATE_MAIN_I3" I wonder how useful is this line, in a typical user case. Why not change to a debug line? I have no problem with mak

Re: [Swan-dev] xauth_send_request has a comment that confuses me

2017-10-12 Thread Paul Wouters
On Mon, 9 Oct 2017, Antony Antony wrote: You could look at (st->st_connection->policy & POLICY_AGGRESSIVE) to determine that. But again, I don't see why knowing this should make a difference to the retransmit timer code. It seems different. Atleast in our test cases, and smc entry supprt this

Re: [Swan-dev] defaulting libreswan build to linux

2017-10-12 Thread Paul Wouters
On Wed, 11 Oct 2017, Andrew Cagney wrote: I'm considering merging much of mk/defaults/linux.mk into mk/config.mk so that config.mk just defaults everything to the typical linux value. This would mean removing the esoteric checks for other OS variants - if an OS needs those overrides then they

Re: [Swan-dev] pfree checks

2017-10-12 Thread Paul Wouters
Seems useful to me Sent from my iPhone > On Oct 7, 2017, at 13:29, Andrew Cagney wrote: > > I'm considering a commit containing some of the below additional checks: > > - try to spot a double free (I think this check should go in) > > - try to spot a use-after-free, not so sure about this >

Re: [Swan-dev] DPD code mystery

2017-10-12 Thread Paul Wouters
On Sun, 8 Oct 2017, D. Hugh Redelmeier wrote: Can someone who understands DPD have a look at this? in complete_v1_state_transition: /* * make sure that a DPD event gets created for a new phase 1 * SA. */ It's weird that this