Re: [Swan-dev] Vendor ID ambiguity

2018-07-30 Thread Paul Wouters
On Mon, 30 Jul 2018, D. Hugh Redelmeier wrote: Some of our code emits our vendorid payload using libreswan_vendorid as our Vendor ID using out_vid( ..., VID_LIBRESWANSELF); and some uses pluto_vendorid, via ikev1_out_generic_raw(). Those are two different things, Which one is correct

[Swan-dev] Vendor ID ambiguity

2018-07-30 Thread D. Hugh Redelmeier
Some of our code emits our vendorid payload using libreswan_vendorid as our Vendor ID using out_vid( ..., VID_LIBRESWANSELF); and some uses pluto_vendorid, via ikev1_out_generic_raw(). Those are two different things, Which one is correct? I'm operating on the code and I'd like to get t

Re: [Swan-dev] Clearing the deck for the f28 switch ...

2018-07-30 Thread Andrew Cagney
On Mon, 30 Jul 2018 at 16:38, Paul Wouters wrote: > > On Sat, 28 Jul 2018, Andrew Cagney wrote: > > >> Please don’t. > >> > >> Some tests were put in wip when they shouldn’t have been are were > >> neglected as a result. > > > > I don't follow. > > > > Surely any test that consistently fails is g

Re: [Swan-dev] Clearing the deck for the f28 switch ...

2018-07-30 Thread Paul Wouters
On Sat, 28 Jul 2018, Andrew Cagney wrote: Please don’t. Some tests were put in wip when they shouldn’t have been are were neglected as a result. I don't follow. Surely any test that consistently fails is going to get ignored. But less so when they dont appear anywhere whatsoever or are de