Re: [Swan-dev] regarding: testing: adding missing : ==== end ==== to nicinit

2020-01-29 Thread Paul Wouters
On Wed, 29 Jan 2020, Antony Antony wrote: I'm happy to do this after the 3.30 release. Just to be very sure, is there anything needing the initdone markers still? A grep in testing/utils/* shows nothing. If no one can think of anything, I will also take those out when I do this work. I am

Re: [Swan-dev] regarding: testing: adding missing : ==== end ==== to nicinit

2020-01-29 Thread Antony Antony
On Wed, Jan 29, 2020 at 04:00:10AM -0500, Paul Wouters wrote: > On Tue, 28 Jan 2020, Antony Antony wrote: > > > > I understand that is your preference if _any_ solution is needed. But you > > > didn't answer my real question. Is there any test case that functionally > > > needs to run final.sh on

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-29 Thread Paul Wouters
On Wed, 29 Jan 2020, Antony Antony wrote: summary s/iface-ip/interface-ip/ Disable the keyword until the functionality is added. syntax interface-ip=1.2.3.3/24 does that mean it would no longer be left/right? Or do you mean it will become leftinterface-ip= and rightinterface-ip= ? Antony

Re: [Swan-dev] regarding: testing: adding missing : ==== end ==== to nicinit

2020-01-29 Thread Paul Wouters
On Tue, 28 Jan 2020, Andrew Cagney wrote: final.sh has really been overloaded when what was needed was something running on east after the run.sh. We have the numbered .sh method for that now (especially if support for that is added to namespaces) I thought that worked. The code's in

Re: [Swan-dev] regarding: testing: adding missing : ==== end ==== to nicinit

2020-01-29 Thread Paul Wouters
On Tue, 28 Jan 2020, Antony Antony wrote: I understand that is your preference if _any_ solution is needed. But you didn't answer my real question. Is there any test case that functionally needs to run final.sh on nic? Do we have a test that is simple enough that it uses init/run/final, yet

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-29 Thread Antony Antony
summary s/iface-ip/interface-ip/ Disable the keyword until the functionality is added. syntax interface-ip=1.2.3.3/24 Antony foresee new type ttipcider(), as there are objections to reuse subnet(). We will see when we add the code. If the subnet is left alone without port and protocol it can