[Swan-dev] testing: swan-prep break on conflicting config files

2020-09-21 Thread Andrew Cagney
FYI, I removed the code because it seemed arbitrary. It would reject some, but not all combinations of: west.ipsec.secrets westipsec.secrets west.secrets ipsec.secrets I figured reducing this list to just: west.ipsec.secrets ipsec.secrets (and perhaps only allowing one) + log

Re: [Swan-dev] testing: swan-prep break on conflicting config files

2020-09-21 Thread Paul Wouters
On Mon, 21 Sep 2020, Andrew Cagney wrote: Subject: [Swan-dev] testing: swan-prep break on conflicting config files FYI, I removed the code because it seemed arbitrary.  It would reject some, but not all combinations of:     west.ipsec.secrets     westipsec.secrets     west.secrets     ipsec.se

Re: [Swan-dev] testing: swan-prep break on conflicting config files

2020-09-21 Thread Antony Antony
Hi Andrew, I do not quite follow your arguments. when did wel allow west.ipsec.secrets to work? It should not work! I had quick look at v3.30 west.ipsec.secrets would not be copied instead /etc/baseconfig/host/etc/ipsec.secerts will be copied as /etc/ipsec.secrets. For host specific secerts fi

Re: [Swan-dev] nat: ikeport commit broke DDNS tests

2020-09-21 Thread Paul Wouters
On Sun, 20 Sep 2020, Paul Wouters wrote: Subject: [Swan-dev] nat: ikeport commit broke DDNS tests Fixed with commit 82ffa122d2500bb7a4 That's probably a bandaid and not the best solution, but it can be cleaned up later when we cleanup the port variables more. Paul ___

Re: [Swan-dev] nat: ikeport commit broke DDNS tests

2020-09-21 Thread Andrew Cagney
On Mon, 21 Sep 2020 at 13:53, Paul Wouters wrote: > On Sun, 20 Sep 2020, Paul Wouters wrote: > > > Subject: [Swan-dev] nat: ikeport commit broke DDNS tests > > Fixed with commit 82ffa122d2500bb7a4 > > That's probably a bandaid and not the best solution, but it can be > cleaned up later when we cl

Re: [Swan-dev] testing: swan-prep break on conflicting config files

2020-09-21 Thread Antony Antony
Andrew, after a closer look I see l2tp and ppp configuration file could be in the form 'hostname + "." + config_file' in the test directory. ikev1-l2tp-01/north.xl2tpd.conf they are not copied using the function that got fixed in 1e0b14ec0b. Now I am confused why this commit added 'hostname +

Re: [Swan-dev] testing: swan-prep break on conflicting config files

2020-09-21 Thread Andrew Cagney
On Mon, 21 Sep 2020 at 15:32, Antony Antony wrote: > Andrew, > > after a closer look I see l2tp and ppp configuration file could be in the > form 'hostname + "." + config_file' in the test directory. > > ikev1-l2tp-01/north.xl2tpd.conf > > they are not copied using the function that got fixed in

Re: [Swan-dev] testing: swan-prep break on conflicting config files

2020-09-21 Thread Paul Wouters
On Mon, 21 Sep 2020, Andrew Cagney wrote: Date: Mon, 21 Sep 2020 17:07:27 From: Andrew Cagney Cc: Libreswan Development List To: Antony Antony Subject: Re: [Swan-dev] testing: swan-prep break on conflicting config files On Mon, 21 Sep 2020 at 15:32, Antony Antony wrote: Andrew,

Re: [Swan-dev] can add connection require a private key?

2020-09-21 Thread Andrew Cagney
On Sun, 20 Sep 2020 at 22:16, Paul Wouters wrote: > On Sun, 20 Sep 2020, Andrew Cagney wrote: > > > - if orient() tries to load a cert and fails, should the connection be > tossed or left unoriented? > > It's too late than isn't it? The connection is already loaded before > orient() can be called

[Swan-dev] testing: bump machine type in host xml files from pc-0.15 to pc-q35-5.1

2020-09-21 Thread Andrew Cagney
- hvm + hvm I suspect this is connected to: error: Failed to start domain w5.nic error: internal error: process exited while connecting to monitor: 2020-09-21T22:52:01.064369Z qemu-system-x86_64: -machine accel=kvm: unsupported machine type https://testing.libreswan.org/v3.30-1740-g2dd505be5b-ma

Re: [Swan-dev] nat: ikeport commit broke DDNS tests

2020-09-21 Thread Andrew Cagney
This comment is salient: /* * .has_client means that .client contains a hardwired value, * if it doesn't then it is filled in later (for instance by * instantiate() calling default_end() after host_addr is * known). */ the ddns code isn't calling

[Swan-dev] New Defects reported by Coverity Scan for antonyantony/libreswan

2020-09-21 Thread scan-admin
Hi, Please find the latest report on new defect(s) introduced to antonyantony/libreswan found with Coverity Scan. 1 new defect(s) introduced to antonyantony/libreswan found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1497108: Null pointer der