Re: [Swan-dev] what is INTERFACE_IP / ifaceip / interface-ip= for?

2021-01-04 Thread Antony Antony
On Sun, Jan 03, 2021 at 11:54:30AM -0500, Paul Wouters wrote: > On Sun, 3 Jan 2021, Andrew Cagney wrote: > > > Subject: [Swan-dev] what is INTERFACE_IP / ifaceip / interface-ip= for? > > > I suspect it has something to do with XFRMI. As best I can, in the > > current code, it is simply being pas

Re: [Swan-dev] libswan: ip_endpoint.c: endpoint_eq(): simplify

2021-01-04 Thread D. Hugh Redelmeier
| From: Andrew Cagney | Shorter? Yes. | Simpler? No. Why doesn't it seem simpler to you? It looks simpler to me. Here's why I think that I think so: - shorter (shorter is often, but not always, simpler) - a lot less clutter to be understood - one statement instead of 13 (not counting two th

[Swan-dev] for DNS, try IPv4 before IPv6

2021-01-04 Thread Andrew Cagney
ttoaddr() contains: - if (err && af != AF_INET) - err = tryname(src, srclen, nultermd, AF_INET6, af, dst); - if (err && af != AF_INET6) - err = tryname(src, srclen, nultermd, AF_INET, af, dst); so, for AF==AF_UNSPEC, it will tr

Re: [Swan-dev] for DNS, try IPv4 before IPv6

2021-01-04 Thread Paul Wouters
On Jan 4, 2021, at 20:14, Andrew Cagney wrote: > > So to put it simply: whack prefers IPv4; ttoaddr() prefers IPv6. This > means that, if the whack default is removed, a configuration with > valid IPv4 and IPv6 DNS records would suddenly switch from IPv4 to > IPv6 for the IKE SA. That’s fine