Re: [Swan-dev] resolve_myid()

2017-07-06 Thread Andrew Cagney
On 4 July 2017 at 14:17, D. Hugh Redelmeier wrote: > | From: D. Hugh Redelmeier > > | Here's the definition: > | > | const struct id *resolve_myid(const struct id *id) > | { > | return id; > | } > > I'm quite wrong. > > That is only one definition, in lib/liblswlog/lswid.c > There is anoth

Re: [Swan-dev] resolve_myid()

2017-07-04 Thread D. Hugh Redelmeier
| From: D. Hugh Redelmeier | Here's the definition: | | const struct id *resolve_myid(const struct id *id) | { | return id; | } I'm quite wrong. That is only one definition, in lib/liblswlog/lswid.c There is another definition in programs/pluto/myid.c That one does do something useful.

Re: [Swan-dev] resolve_myid()

2017-07-04 Thread Paul Wouters
Kill it Sent from my iPhone > On Jul 4, 2017, at 17:59, D. Hugh Redelmeier wrote: > > I'm sorry that my question wasn't clearer. > > Here's the definition: > > const struct id *resolve_myid(const struct id *id) > { >return id; > } > > It clearly does NOTHING. It does not allow roadwarri

Re: [Swan-dev] resolve_myid()

2017-07-04 Thread D. Hugh Redelmeier
I'm sorry that my question wasn't clearer. Here's the definition: const struct id *resolve_myid(const struct id *id) { return id; } It clearly does NOTHING. It does not allow roadwarriors to declare their ID since it does nothing. If we intend to build on it later, that's fine. But a

[Swan-dev] resolve_myid()

2017-07-04 Thread Paul Wouters
What's the point of resolve_myid()? It seems like it doesn't do anything (formally: it is the identity function). Did it formerly have a purpose? Does it have a future purpose? It was used for roadwarriors to declare their ID to allow forward DNS lookups for IPSECKEY (aka "Initiator only OE

[Swan-dev] resolve_myid()

2017-06-29 Thread D. Hugh Redelmeier
What's the point of resolve_myid()? It seems like it doesn't do anything (formally: it is the identity function). Did it formerly have a purpose? Does it have a future purpose? If it is pointless, let's get rid of it. And the sourcefile lswid.c that contains only the definition of resolve_m