Re: [Swan-dev] XFRM IP ref-counting testing PR

2023-07-21 Thread Brady Johnson
Antony, Regarding the error you found in ip_addr_xfrmi_store_ips(), I fixed that and pushed the change to the PR. It was a simple issue in init_pluto_xfrmi(). It was trying to query the IPs on the interface before the interface was created. I added a simple dev_exists_check() check to only do

Re: [Swan-dev] XFRM IP ref-counting testing PR

2023-07-20 Thread Antony Antony
On Thu, Jul 20, 2023 at 07:07:31PM +0200, Antony Antony wrote: > Hi Brady, > > See some feedback from testing your latest branch, from an hour ago. > > On Thu, Jul 20, 2023 at 05:07:10PM +0200, Brady Johnson wrote: > > Hello, > > > > I submit several patch sets to my XFRM IP ref-counting PR [0]

Re: [Swan-dev] XFRM IP ref-counting testing PR

2023-07-20 Thread Antony Antony
Hi Brady, See some feedback from testing your latest branch, from an hour ago. On Thu, Jul 20, 2023 at 05:07:10PM +0200, Brady Johnson wrote: > Hello, > > I submit several patch sets to my XFRM IP ref-counting PR [0] in the past > few days. I fixed the assert/segfault that Antony reported on

[Swan-dev] XFRM IP ref-counting testing PR

2023-07-20 Thread Brady Johnson
Hello, I submit several patch sets to my XFRM IP ref-counting PR [0] in the past few days. I fixed the assert/segfault that Antony reported on the PR, plus several other fixes and improvements. I created a slide [1] explaining the manual testing I have performed. Can I get a code review of the