Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-31 Thread Antony Antony
On Thu, Jan 30, 2020 at 10:35:48AM -0500, Andrew Cagney wrote: > On Wed, 29 Jan 2020 at 04:06, Paul Wouters wrote: > > > > On Wed, 29 Jan 2020, Antony Antony wrote: > > > > > Antony foresee new type ttipcider(), as there are objections to reuse > > > subnet(). We will see when we add the code. If

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-30 Thread Andrew Cagney
On Wed, 29 Jan 2020 at 04:06, Paul Wouters wrote: > > On Wed, 29 Jan 2020, Antony Antony wrote: > > > Antony foresee new type ttipcider(), as there are objections to reuse > > subnet(). We will see when we add the code. If the subnet is left alone > > without port and protocol it can used for ttip

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-29 Thread Paul Wouters
On Wed, 29 Jan 2020, Antony Antony wrote: summary s/iface-ip/interface-ip/ Disable the keyword until the functionality is added. syntax interface-ip=1.2.3.3/24 does that mean it would no longer be left/right? Or do you mean it will become leftinterface-ip= and rightinterface-ip= ? Antony fo

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-29 Thread Antony Antony
summary s/iface-ip/interface-ip/ Disable the keyword until the functionality is added. syntax interface-ip=1.2.3.3/24 Antony foresee new type ttipcider(), as there are objections to reuse subnet(). We will see when we add the code. If the subnet is left alone without port and protocol it can us

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-28 Thread Paul Wouters
On Mon, 27 Jan 2020, D. Hugh Redelmeier wrote: Subject: Re: [Swan-dev] better name for {left,right}ifaceip? General comment: We have way too many options. We cannot lightly delete any that have been advertised in a release. Has iface-ip been advertised? It hasnt been advertised yet, as I

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-28 Thread Paul Wouters
On Mon, 27 Jan 2020, Antony Antony wrote: On Mon, Jan 27, 2020 at 10:58:45AM -0500, D. Hugh Redelmeier wrote: Has iface-ip been advertised? no. code is incomplete. We can change at this point. I would be happy to. yes we can still change it until we release 3.30. This option has not appeare

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-27 Thread Andrew Cagney
On Mon, 27 Jan 2020 at 11:39, Antony Antony wrote: > > first quick answer to Hugh's follow up questions. > > On Mon, Jan 27, 2020 at 10:58:45AM -0500, D. Hugh Redelmeier wrote: > > Has iface-ip been advertised? > > no. code is incomplete. We can change at this point. I would be happy to. > Though

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-27 Thread Antony Antony
first quick answer to Hugh's follow up questions. On Mon, Jan 27, 2020 at 10:58:45AM -0500, D. Hugh Redelmeier wrote: > Has iface-ip been advertised? no. code is incomplete. We can change at this point. I would be happy to. Though Paul may have signoff. My recollection is, he want something simil

Re: [Swan-dev] better name for {left,right}ifaceip?

2020-01-27 Thread D. Hugh Redelmeier
General comment: We have way too many options. We cannot lightly delete any that have been advertised in a release. Has iface-ip been advertised? Andrew's points all seem valid too. But I haven't thought deeply about this. ___ Swan-dev mailing list S

[Swan-dev] better name for {left,right}ifaceip?

2020-01-27 Thread Andrew Cagney
I noticed this user visible addition: whack.h: ip_subnet ifaceip; keywords.c:509: { "iface-ip", kv_conn | kv_leftright , kt_subnet, KSCF_IFACE_IP, NULL, NULL, }, the problem I see is that, contrary to the name, it isn't an IP (i.e, ip address). Rather, to use IKEv2 terminology, its a tra