Re: [Swan-dev] crash introduced in c2ea0911 while replacing IKEv1 ISKAMP SA

2016-11-14 Thread Matt Rogers
On Sat, 2016-11-12 at 10:21 +0200, Tuomo Soini wrote: > On Fri, 11 Nov 2016 13:47:03 -0500 > Matt Rogers wrote: > > > > > I've added a patch and comment to the bug; with 14348a4e reverted > > and > > the patch applied, there should be no more leaks or double-free of > > the > > gn. > > > > Matt

Re: [Swan-dev] crash introduced in c2ea0911 while replacing IKEv1 ISKAMP SA

2016-11-12 Thread Tuomo Soini
On Fri, 11 Nov 2016 13:47:03 -0500 Matt Rogers wrote: > I've added a patch and comment to the bug; with 14348a4e reverted and > the patch applied, there should be no more leaks or double-free of the > gn. > > Matt Thank you Matt for fixing the real issue. Please commit your fix to master and le

Re: [Swan-dev] crash introduced in c2ea0911 while replacing IKEv1 ISKAMP SA

2016-11-11 Thread Matt Rogers
On Wed, 2016-11-02 at 20:32 +0200, Tuomo Soini wrote: > On Sat, 29 Oct 2016 19:10:18 +0200 > Antony Antony wrote: > > > > > c2ea0911 introduced a crasher for IKEv1. When pluto replace IKE SA > > and delete itself. > > > > #0  0x5610ca3c34b7 in free_generalNames (gn=0xe, free_name=1) > >    

Re: [Swan-dev] crash introduced in c2ea0911 while replacing IKEv1 ISKAMP SA

2016-11-02 Thread Tuomo Soini
On Sat, 29 Oct 2016 19:10:18 +0200 Antony Antony wrote: > c2ea0911 introduced a crasher for IKEv1. When pluto replace IKE SA > and delete itself. > > #0 0x5610ca3c34b7 in free_generalNames (gn=0xe, free_name=1) > at /home/build/libreswan/lib/libswan/x509dn.c:742 > #1 0x5610ca329edb

[Swan-dev] crash introduced in c2ea0911 while replacing IKEv1 ISKAMP SA

2016-10-29 Thread Antony Antony
c2ea0911 introduced a crasher for IKEv1. When pluto replace IKE SA and delete itself. #0 0x5610ca3c34b7 in free_generalNames (gn=0xe, free_name=1) at /home/build/libreswan/lib/libswan/x509dn.c:742 #1 0x5610ca329edb in delete_state (st=0x5610cb16eaa0) at /home/build/libreswan/progra