Re: [Swan-dev] impair variable names

2020-04-02 Thread Andrew Cagney
Tried it. It reads well when what is being impaired is a boolean vis: if (IMPAIR(send_bogus_isakmp_flag)) { hdr.isa_flags |= ISAKMP_FLAGS_RESERVED_BIT6; } however, think it breaks down for more complex values. For instance, this would look decidedly weird iv IMPAIR() was used. fixu

Re: [Swan-dev] impair variable names

2020-04-01 Thread Paul Wouters
Works for me Sent from my iPhone > On Apr 1, 2020, at 19:38, Andrew Cagney wrote: > >  > > >> On Wed, 1 Apr 2020 at 18:10, Antony Antony wrote: >> On Mon, Mar 30, 2020 at 12:07:17PM -0400, Andrew Cagney wrote: >> > I'm cleaning up the impair code. >> > >> > Internally, the old style #defin

Re: [Swan-dev] impair variable names

2020-04-01 Thread Andrew Cagney
On Wed, 1 Apr 2020 at 18:10, Antony Antony wrote: > On Mon, Mar 30, 2020 at 12:07:17PM -0400, Andrew Cagney wrote: > > I'm cleaning up the impair code. > > > > Internally, the old style #define names are in upper case vis: > > #define IMPAIR_REPLAY_FORWARD ... > > and > > IMPAIR(REPLAY_FORWAR

Re: [Swan-dev] impair variable names

2020-04-01 Thread Antony Antony
On Mon, Mar 30, 2020 at 12:07:17PM -0400, Andrew Cagney wrote: > I'm cleaning up the impair code. > > Internally, the old style #define names are in upper case vis: >   #define IMPAIR_REPLAY_FORWARD ... > and >   IMPAIR(REPLAY_FORWARD) > while the new ones (that take parameters) are in lower case

[Swan-dev] impair variable names

2020-03-30 Thread Andrew Cagney
I'm cleaning up the impair code. Internally, the old style #define names are in upper case vis: #define IMPAIR_REPLAY_FORWARD ... and IMPAIR(REPLAY_FORWARD) while the new ones (that take parameters) are in lower case vis: extern enum send_impairment impair_ike_key_length_attribute I've merge