Re: [Swan-dev] testing: drifting reference logs

2015-02-11 Thread Paul Wouters
On Wed, 11 Feb 2015, D. Hugh Redelmeier wrote: | I'm investigating that one. It shows that the counting of states has a | bug in it. Possibly related to deleting states. I just pushed an obvious local fix: that = should be == That doesn't mean that all is well, just that it is more well. Duh

Re: [Swan-dev] testing: drifting reference logs

2015-02-11 Thread D. Hugh Redelmeier
| From: Paul Wouters | On Wed, 11 Feb 2015, Antony Antony wrote: | > "westnet-eastnet": EXPECTATION FAILED at /source/programs/pluto/state.c:176: | > st_parents = st_anonymous + st_authenticated | | I'm investigating that one. It shows that the counting of states has a | bug in it. Possibly rel

Re: [Swan-dev] testing: drifting reference logs

2015-02-11 Thread Paul Wouters
On Wed, 11 Feb 2015, Antony Antony wrote: hmm, #master has an odd EXPECTATION. there is a new EXPECTATION in almost testcases. Is this an exception then? "westnet-eastnet": EXPECTATION FAILED at /source/programs/pluto/state.c:176: st_parents = st_anonymous + st_authenticated I'm investigat

Re: [Swan-dev] testing: drifting reference logs

2015-02-11 Thread Antony Antony
hmm, #master has an odd EXPECTATION. there is a new EXPECTATION in almost testcases. Is this an exception then? it seems to have started after 2015-02-10-blackswan-v3.12-328-ga1344cb-master after commit a1344cb "westnet-eastnet": EXPECTATION FAILED at /source/programs/pluto/state.c:176: st_pare

[Swan-dev] testing: drifting reference logs

2015-02-10 Thread Antony Antony
Recent, Feb 07 the, change to ipsec status output is confusing me. Is this an accident or real? are we changing from ENCRYPT to AUTHENTICATE? -000 "westnet-eastnet": policy: RSASIG+ENCRYPT+TUNNEL+PFS+IKEV1_ALLOW+IKEV2_ALLOW+SAREF_TRACK+IKE_FRAG_ALLOW; +000 "westnet-eastnet": policy: RSAS

Re: [Swan-dev] testing: drifting reference logs

2015-01-06 Thread Paul Wouters
On Tue, 6 Jan 2015, Andrew Cagney wrote: I'm not sure I completely follow: On 6 January 2015 at 13:32, Paul Wouters wrote: 000 000 IKE algorithms supported: +000 +000 [...] 000 The whole point of this output is to see it though. However, in a lot of test cases we currently run just "ipsec

Re: [Swan-dev] testing: drifting reference logs

2015-01-06 Thread Andrew Cagney
I'm not sure I completely follow: On 6 January 2015 at 13:32, Paul Wouters wrote: >> 000 >> 000 IKE algorithms supported: >> +000 >> +000 [...] >> 000 > > > The whole point of this output is to see it though. However, in a lot of > test cases we currently run just "ipsec status" and not "ipsec s

Re: [Swan-dev] testing: drifting reference logs

2015-01-06 Thread Paul Wouters
On Tue, 6 Jan 2015, Andrew Cagney wrote: Perhaps the attached sanitizer will help. It changes this: 000 000 IKE algorithms supported: -000 -000 algorithm IKE encrypt: v1id=5, v1name=OAKLEY_3DES_CBC, v2id=3, v2name=3DES, blocksize=8, keydeflen=192 -000 algorithm IKE encrypt: v1id=24, v1name=OAK

Re: [Swan-dev] testing: drifting reference logs

2015-01-06 Thread Andrew Cagney
Perhaps the attached sanitizer will help. It changes this: 000 000 IKE algorithms supported: -000 -000 algorithm IKE encrypt: v1id=5, v1name=OAKLEY_3DES_CBC, v2id=3, v2name=3DES, blocksize=8, keydeflen=192 -000 algorithm IKE encrypt: v1id=24, v1name=OAKLEY_CAMELLIA_CTR, v2id=24, v2name=CAMELLIA

Re: [Swan-dev] testing: drifting reference logs

2015-01-05 Thread Paul Wouters
On Mon, 5 Jan 2015, Antony Antony wrote: FYI: interop-ikev2-racoon-03-psk-initiator break "make check", because it has an unexpected file eastrun.sh It came from a recenct umlpluto to kvmconversion, ffc7bc4d I am disabling it in TESTLIST; careful while converting old tests! I noticed that too

Re: [Swan-dev] testing: drifting reference logs

2015-01-04 Thread Antony Antony
FYI: interop-ikev2-racoon-03-psk-initiator break "make check", because it has an unexpected file eastrun.sh It came from a recenct umlpluto to kvmconversion, ffc7bc4d I am disabling it in TESTLIST; careful while converting old tests! -antony On Fri, Jan 02, 2015 at 02:36:12PM -0500, Paul Wout

Re: [Swan-dev] testing: drifting reference logs

2015-01-02 Thread Paul Wouters
On Fri, 2 Jan 2015, Antony Antony wrote: We have another output change that affect almost all test cases(200+) now. -000 algorithm IKE encrypt: v1id=13, v1name=DISABLED-OAKLEY_AES_CTR, v2id=13, v2name=AES_CTR, blocksize=16, keydeflen=128 +000 algorithm IKE encrypt: v1id=8, v1name=OAKLEY_CAMELL

Re: [Swan-dev] testing: drifting reference logs

2015-01-02 Thread Antony Antony
We have another output change that affect almost all test cases(200+) now. -000 algorithm IKE encrypt: v1id=13, v1name=DISABLED-OAKLEY_AES_CTR, v2id=13, v2name=AES_CTR, blocksize=16, keydeflen=128 +000 algorithm IKE encrypt: v1id=8, v1name=OAKLEY_CAMELLIA_CBC, v2id=23, v2name=CAMELLIA_CBC, block

Re: [Swan-dev] testing: drifting reference logs

2014-12-30 Thread Paul Wouters
On Tue, 30 Dec 2014, D. Hugh Redelmeier wrote: | From: Antony Antony | Subject: Re: [Swan-dev] testing: more results, where 169.x.x.x is removed | | On Mon, Dec 29, 2014 at 01:56:44AM -0500, D. Hugh Redelmeier wrote: | > | New commits: | > | commit 11749924b5a37c3b0fd6284a7c98cf9caed98212 | >

[Swan-dev] testing: drifting reference logs

2014-12-29 Thread D. Hugh Redelmeier
The test reference logs need to be kept up to date. They need to be in sync with the source code. But they need to be correct: don't make changes that you don't understand. False failures are a significant waste of my time and I'm sure they are a waste of others' time. (False success is evil.)