https://bugs.freedesktop.org/show_bug.cgi?id=45794
Bug #: 45794
Summary: Type error in swfmoz_player_loaders_update
Classification: Unclassified
Product: swfdec
Version: unspecified
Platform: SPARC
OS/Version: NetBSD
Status: NEW
Severity: normal
Priority: medium
Component: plugin
AssignedTo: swfdec@lists.freedesktop.org
ReportedBy: mar...@netbsd.org
QAContact: swfdec@lists.freedesktop.org
The variable "error" is declared as gboolean, but then assigned via a call to
g_object_get() on the "error" property. However, that property is a string (the
error message) or NULL if no error. Since g_object_get() is a variadic
function, the compiler will not catch this.
On alignement critical architectures the pointer assignement to &error may
cause a crash. On others, still some part of the stack may be overwritten.
Fix is simple: declare
gpointer error = NULL;
and change the test from
if (error == TRUE)
to
if (error != NULL)
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.
_______________________________________________
Swfdec mailing list
Swfdec@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/swfdec
