Re: [swift-corelibs-dev] SR-6405: URLRequest does not capitalise HTTP methods

2017-11-16 Thread Stephen Celis via swift-corelibs-dev
> On Nov 16, 2017, at 3:30 PM, Ian Partridge wrote: > >> Is the Foundation test suite run against both implementations to attempt to >> catch these kinds of things? >> If not it would seem like a big win to do so. > > Not yet, but there is work underway to do this. See > https://github.com/app

Re: [swift-corelibs-dev] SR-6405: URLRequest does not capitalise HTTP methods

2017-11-16 Thread Ian Partridge via swift-corelibs-dev
On 16 November 2017 at 17:41, Stephen Celis wrote: > Brandon Williams and I have come across a lot of inconsistencies between > Foundations in our Swift web work. We’ve been trying to file bugs when we > remember to, but I’m curious if there’s a better way to catch these. Please continue to fil

Re: [swift-corelibs-dev] SR-6405: URLRequest does not capitalise HTTP methods

2017-11-16 Thread Stephen Celis via swift-corelibs-dev
> On Nov 16, 2017, at 2:57 PM, Alex Blewitt wrote: > > I understood your question, but I can only point to you as to what is > available and run on the swift-corelibs-foundation open source project. Sorry to continue on this train (especially since it’s a big of a derailment). I’m really not t

Re: [swift-corelibs-dev] SR-6405: URLRequest does not capitalise HTTP methods

2017-11-16 Thread Ian Partridge via swift-corelibs-dev
On 16 November 2017 at 19:02, Alex Blewitt wrote: > Note that there's no requirement for the methods to be capitalised in > URLRequest. I'm not sure what you mean by requirement. It may not be documented, but Darwin does behave this way. > Chances are that the implementation is such that there

Re: [swift-corelibs-dev] SR-6405: URLRequest does not capitalise HTTP methods

2017-11-16 Thread Alex Blewitt via swift-corelibs-dev
> On 16 Nov 2017, at 19:14, Stephen Celis wrote: > >> On Nov 16, 2017, at 2:02 PM, Alex Blewitt wrote: >> >> There is a TestFoundation target in the swift-corelibs-foundation project, >> which can allow the tests to be run against the open source codebase. > > Sorry, maybe I wasn’t clear, I w

Re: [swift-corelibs-dev] SR-6405: URLRequest does not capitalise HTTP methods

2017-11-16 Thread Stephen Celis via swift-corelibs-dev
> On Nov 16, 2017, at 2:02 PM, Alex Blewitt wrote: > > There is a TestFoundation target in the swift-corelibs-foundation project, > which can allow the tests to be run against the open source codebase. Sorry, maybe I wasn’t clear, I was wondering if there’s a test suite that regularly runs aga

Re: [swift-corelibs-dev] SR-6405: URLRequest does not capitalise HTTP methods

2017-11-16 Thread Alex Blewitt via swift-corelibs-dev
There is a TestFoundation target in the swift-corelibs-foundation project, which can allow the tests to be run against the open source codebase. Note that there's no requirement for the methods to be capitalised in URLRequest. Chances are that the implementation is such that there are some pre-

Re: [swift-corelibs-dev] SR-6405: URLRequest does not capitalise HTTP methods

2017-11-16 Thread Stephen Celis via swift-corelibs-dev
Brandon Williams and I have come across a lot of inconsistencies between Foundations in our Swift web work. We’ve been trying to file bugs when we remember to, but I’m curious if there’s a better way to catch these. Is the Foundation test suite run against both implementations to attempt to catc

[swift-corelibs-dev] SR-6405: URLRequest does not capitalise HTTP methods

2017-11-16 Thread Ian Partridge via swift-corelibs-dev
Hi, it looks like Foundation on Darwin capitalises certain HTTP methods but not others: ``` let methods = ["get", "head", "post", "put", "delete", "connect", "options", "trace", "patch"] var x = URLRequest(url: URL(string: "/hello")!) for m in methods { x.httpMethod = m print(x.httpMetho