Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #7135

2016-11-10 Thread Mark Lacey via swift-dev
Hi Sean, There appears to be a dependency issue in the clang build that is causing this. It (and another similar assert related to diagnostics) started showing up after we pulled in a diagnostics change this morning. You can ignore the failure. Hopefully we can get this fixed quickly. Mark

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #7135

2016-11-10 Thread Sean Callanan via swift-dev
I tested my commit several times and the codepaths I changed do not affect swift compilation (it doesn't use the ASTImporter). The error is – Assertion failed: (ModifierLen == 0 && "Unknown integer modifier"), function FormatDiagnostic, file /Users/buildnode/jenkins/workspace/oss-swift-increment

Re: [swift-dev] Compiler crash: is this a bug in Swift or Xcode?

2016-11-10 Thread Nevin Brackett-Rozinsky via swift-dev
Thank you both. Nevin On Thu, Nov 10, 2016 at 6:57 PM, Jordan Rose wrote: > > On Nov 10, 2016, at 11:19, Joe Groff via swift-dev > wrote: > > > On Nov 10, 2016, at 10:48 AM, Nevin Brackett-Rozinsky via swift-dev < > swift-dev@swift.org> wrote: > > When I put these two lines in a Swift file in

Re: [swift-dev] Compiler crash: is this a bug in Swift or Xcode?

2016-11-10 Thread Jordan Rose via swift-dev
> On Nov 10, 2016, at 11:19, Joe Groff via swift-dev > wrote: > > >> On Nov 10, 2016, at 10:48 AM, Nevin Brackett-Rozinsky via swift-dev >> mailto:swift-dev@swift.org>> wrote: >> >> When I put these two lines in a Swift file in Xcode (8.1), I get both >> “SourceKitService quit unexpectedly”

Re: [swift-dev] Glibc.swift: error: no such module 'SwiftGlibc'

2016-11-10 Thread Jordan Rose via swift-dev
> On Nov 10, 2016, at 15:16, Eric Wing wrote: > > On 11/10/16, Jordan Rose > wrote: >> >>> On Nov 10, 2016, at 13:34, Eric Wing wrote: >>> >>> On 11/9/16, Eric Wing wrote: On 11/9/16, Eric Wing wrote: > On 11/9/16, Jordan Rose wrote: >> Ah, that

Re: [swift-dev] Glibc.swift: error: no such module 'SwiftGlibc'

2016-11-10 Thread Eric Wing via swift-dev
On 11/10/16, Jordan Rose wrote: > >> On Nov 10, 2016, at 13:34, Eric Wing wrote: >> >> On 11/9/16, Eric Wing wrote: >>> On 11/9/16, Eric Wing wrote: On 11/9/16, Jordan Rose wrote: > Ah, that does help. The logic to build the Glibc module map comes from > stdlib/public/Platform/CMa

Re: [swift-dev] Glibc.swift: error: no such module 'SwiftGlibc'

2016-11-10 Thread Jordan Rose via swift-dev
> On Nov 10, 2016, at 13:34, Eric Wing wrote: > > On 11/9/16, Eric Wing wrote: >> On 11/9/16, Eric Wing wrote: >>> On 11/9/16, Jordan Rose wrote: Ah, that does help. The logic to build the Glibc module map comes from stdlib/public/Platform/CMakeLists.txt, and explicitly checks for >

Re: [swift-dev] Glibc.swift: error: no such module 'SwiftGlibc'

2016-11-10 Thread William Dillon via swift-dev
Thanks so much for getting to the bottom of this! I was getting by with hacks to get around this for a while.  I'm very glad we have a reproducible change that triggers. - Will On November 10, 2016 at 1:34:27 PM, Eric Wing via swift-dev (swift-dev@swift.org) wrote: On 11/9/16, Eric Wing wrot

Re: [swift-dev] Glibc.swift: error: no such module 'SwiftGlibc'

2016-11-10 Thread Eric Wing via swift-dev
On 11/9/16, Eric Wing wrote: > On 11/9/16, Eric Wing wrote: >> On 11/9/16, Jordan Rose wrote: >>> Ah, that does help. The logic to build the Glibc module map comes from >>> stdlib/public/Platform/CMakeLists.txt, and explicitly checks for >>> “LINUX”, >>> “FREEBSD”, “ANDROID”, and “CYGWIN”. Does

Re: [swift-dev] Pure Cocoa NSNumbers and AnyHashable

2016-11-10 Thread Joe Groff via swift-dev
> On Nov 10, 2016, at 10:30 AM, Philippe Hausler wrote: > > So I think there are a few rough edges here not just the hashing or equality. > I think the issue comes down to the subclass of NSNumber that is being used - > it is defeating not only hashing but also performance and allocation > op

Re: [swift-dev] Compiler crash: is this a bug in Swift or Xcode?

2016-11-10 Thread Joe Groff via swift-dev
> On Nov 10, 2016, at 10:48 AM, Nevin Brackett-Rozinsky via swift-dev > wrote: > > When I put these two lines in a Swift file in Xcode (8.1), I get both > “SourceKitService quit unexpectedly” and “lldb-rpc-server quit unexpectedly”: > > func f(_ a: Int, _ b: Int) { } > func f(_ ab: (Int, Int)

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #421

2016-11-10 Thread Nico Weber via swift-dev
Thanks! On Tue, Nov 8, 2016 at 12:17 PM, mishal_shah wrote: > Hi Nico, > > Sorry about this, I will make sure to update the Jobs ignore ninja change > set. > > Thanks, > Mishal Shah > > On Nov 8, 2016, at 10:23 AM, Jordan Rose wrote: > > Definitely a mistake on our part. We use Ninja but should

[swift-dev] Compiler crash: is this a bug in Swift or Xcode?

2016-11-10 Thread Nevin Brackett-Rozinsky via swift-dev
When I put these two lines in a Swift file in Xcode (8.1), I get both “SourceKitService quit unexpectedly” and “lldb-rpc-server quit unexpectedly”: func f(_ a: Int, _ b: Int) { } func f(_ ab: (Int, Int)) { } Where should I file a bug report? Nevin ___

Re: [swift-dev] Pure Cocoa NSNumbers and AnyHashable

2016-11-10 Thread Joe Groff via swift-dev
A quick ping. I'd like some feedback about how to address this problem. -Joe > On Nov 2, 2016, at 10:26 AM, Joe Groff via swift-dev > wrote: > > There's a hole in our AnyHashable implementation when it comes to what I'll > call "pure" NSNumbers coming from Cocoa, which were instantiated using

Re: [swift-dev] Type Pun in Test Suite

2016-11-10 Thread Jordan Rose via swift-dev
> On Nov 9, 2016, at 17:30, Alexis via swift-dev wrote: > > Just stumbled across this mock NSDictionary implementation in the test suite: > > https://github.com/apple/swift/blob/a1dbe066adf826b27dd8e71234ba7e8ce2b26b73/validation-test/stdlib/Dictionary.swift#L1260-L1306 > >