Re: [swift-dev] [Discussion] New refcount representation

2016-03-19 Thread Arnold Schwaighofer via swift-dev
I think maybe we also want to measure how a cmpxchg vs lck;add solution performs under contention. Objects in read only state (be it cow’ed value types or not) might be shared between threads with the expectation that they are fast, i.e. the argument if retain/release are contented something el

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #5220

2016-06-08 Thread Arnold Schwaighofer via swift-dev
This might be a spurious failure. I suggest waiting for the next build to see if sticks. > On Jun 8, 2016, at 9:43 AM, Austin Zheng wrote: > > The test that's failing is a test that should be unrelated to the change I > made (I added a few tests and removed two comments from `String.swift`).

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #5124

2016-07-12 Thread Arnold Schwaighofer via swift-dev
I created a pull request here: https://github.com/apple/swift/pull/3476 > On Jul 12, 2016, at 1:05 PM, Mishal Shah via swift-dev > wrote: > > We are also seeing these failures in swift-3.0-preview-3-branch, can we pull > this in to swift-3.0-preview-3-branch? > > https://ci.swift.org/view/s

Re: [swift-dev] Implementation of swift's value types

2016-07-14 Thread Arnold Schwaighofer via swift-dev
Hi Johannes, thank you for your questions. Answers inline. > On Jul 14, 2016, at 12:39 PM, Johannes Neubauer via swift-dev > wrote: > > Dear Devs, > > I saw the WWDC 2016 video [Understanding Swift Performance][0] as well as > some others regarding value types in swift of WWDC2015. I think

Re: [swift-dev] Could not find a package configuration file provided by "Clang"

2016-07-21 Thread Arnold Schwaighofer via swift-dev
Somewhat wild guess. What is the version of your cmake install? I think we started requiring some 3ish version recently. Maybe you need a newer version … > On Jul 20, 2016, at 2:07 PM, Erica Sadun via swift-dev > wrote: > > I started with an absolutely clean re-clone, used bash (normally I us

Re: [swift-dev] High-level SIL Optimization: How do I get a FuncRef from the stdlib?

2016-11-16 Thread Arnold Schwaighofer via swift-dev
> On Wed, Nov 16, 2016 at 12:01 AM Michael Gottesman > wrote: >> On Nov 15, 2016, at 8:54 PM, Ben Ng wrote: >> >> Hi Michael, >> >> It can probably be stuck in the Array Value Propagation pass since its >> pretty similar. Yes, it uses Array semantics. I isolated it in a separate >> file bec

Re: [swift-dev] High-level SIL Optimization: How do I get a FuncRef from the stdlib?

2016-11-16 Thread Arnold Schwaighofer via swift-dev
> On Nov 16, 2016, at 2:58 PM, Ben Ng wrote: > > Correct, that is what I am trying to do. > >> On Nov 16, 2016, at 12:22 PM, Arnold Schwaighofer >> wrote: >> >> // Really, by the time you look at this in array value prop >> // this call should have been inline and you would see a call >>

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 - Long Test (master) #505

2017-01-11 Thread Arnold Schwaighofer via swift-dev
I have reverted the commit to get the bot blue again. > On Jan 10, 2017, at 2:31 PM, Jordan Rose via swift-dev > wrote: > > Alex, I think this was revealed by your commit, but it seems like it should > have always been a problem for swift-corelibs-libdispatch. Any ideas? > > Jordan > >> On J

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1327

2017-01-11 Thread Arnold Schwaighofer via swift-dev
Missing dependency? Can we clean the workspace of the bot? > On Jan 11, 2017, at 10:55 AM, Doug Coleman wrote: > > 534f49bea4aeab5306bb9f2fdb7724d7e36803ef possibly caused this? Also, > shouldn’t it have done some work to recompile after the code changed? > > + pushd > /home/buildnode/jenkin

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1327

2017-01-11 Thread Arnold Schwaighofer via swift-dev
Mishal cleaned the workspace. So the next build hopefully is blue again. > On Jan 11, 2017, at 10:56 AM, Arnold Schwaighofer via swift-dev > wrote: > > Missing dependency? Can we clean the workspace of the bot? > >> On Jan 11, 2017, at 10:55 AM, Doug Coleman > <ma

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #613

2017-01-17 Thread Arnold Schwaighofer via swift-dev
I have reverted f7836ae0c86726723bb11c7cb7f7ab04a57294c9 using PR https://github.com/apple/swift/pull/6852 > On Jan 17, 2017, at 12:12 AM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04 [#613] > > Build URL: > https://ci.swift.org/job/oss-swift-increme

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 14.04 (master) #114

2017-01-17 Thread Arnold Schwaighofer via swift-dev
I have reverted f7836ae0c86726723bb11c7cb7f7ab04a57294c9 using PR https://github.com/apple/swift/pull/6852 > On Jan 17, 2017, at 3:22 AM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-package-linux-ubuntu-14_04 [#114] > > Build URL: > https:/

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 - Long Test (master) #599

2017-01-17 Thread Arnold Schwaighofer via swift-dev
I have reverted f7836ae0c86726723bb11c7cb7f7ab04a57294c9 using PR https://github.com/apple/swift/pull/6852 > On Jan 17, 2017, at 12:12 AM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04-long-test [#599] > > Build

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1417

2017-01-17 Thread Arnold Schwaighofer via swift-dev
I think this one needs a clean workspace. I kicked off a run of clean-workspace-linux-4. https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/ > On Jan 17, 2017, at 7:22 AM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#1417] > > Build

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1549

2017-01-25 Thread Arnold Schwaighofer via swift-dev
This is most likely a CMake dependency failure that goes away when you do a clean build. oss-swift-incremental-RA-linux-ubuntu-16_10: undefined symbol: _TFsoi1pu0_Rxs26RangeReplaceableCollection_S_Wx8Iterator7Element_zW_S0_S1__rFTxq__x https://bugs.swift.org/browse/SR-3621 > On Jan 24, 2017,

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1693

2017-02-03 Thread Arnold Schwaighofer via swift-dev
Yes. https://bugs.swift.org/browse/SR-1517 https://bugs.swift.org/browse/SR-3621 > On Feb 2, 2017, at 10:18 PM, Douglas Gregor via swift-dev > wrote: > > /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_10/buildbot_incremental/foundation-linux-x86_64/TestFoundation/Te

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1892

2017-02-13 Thread Arnold Schwaighofer via swift-dev
This seems to be a non-deterministic failure. Has failed before this commit here: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/1878/ > On Feb 13, 2017, at 1:25 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#1892] > > Build URL

Re: [swift-dev] Tips for debugging interactions between optimization passes

2017-03-03 Thread Arnold Schwaighofer via swift-dev
Some documentation about debugging the swift compiler: https://github.com/apple/swift/blob/master/docs/DebuggingTheCompiler.rst Possibly, not all flags are documented: https://github.com/apple/swift/blob/master/lib/SILOp

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - OS X (master) #9104

2017-03-29 Thread Arnold Schwaighofer via swift-dev
https://bugs.swift.org/browse/SR-4419 I have disabled another swiftpm test in a follow-up commit. > On Mar 29, 2017, at 8:36 AM, no-re...@swift.org wrote: > > New issue found! > > [FAILURE] oss-swift-incremental-RA-osx [#9104] > > Build URL:https://

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #2700

2017-03-29 Thread Arnold Schwaighofer via swift-dev
It was the executable under it. I reproduced this locally on rad by: $ (mistakenly) compiling an older commit $ git pull —rebase $ compiling again => failure occurred I was suspicious of incremental so: $ rm -rf build/buildbot_incremental/foundation-linux-x86_64/ $ build again => worked Runnin

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (swift 4.0) #197

2017-04-26 Thread Arnold Schwaighofer via swift-dev
Syo, This appears to have broken the bot. Can you revert or fix if the next build also fails? > On Apr 26, 2017, at 10:20 AM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-4.0-incremental-RA-linux-ubuntu-16_10 [#197] > > Build URL: > https://ci.swift.org/job/oss-swift-4.0-incremental-R

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (swift 4.0) #197

2017-04-26 Thread Arnold Schwaighofer via swift-dev
10:30 AM, Arnold Schwaighofer via swift-dev > wrote: > > Syo, > > This appears to have broken the bot. > > Can you revert or fix if the next build also fails? > >> On Apr 26, 2017, at 10:20 AM, no-re...@swift.org <mailto:no-re...@swift.org> >> wrote:

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #9701

2017-04-27 Thread Arnold Schwaighofer via swift-dev
Doug this must be yours I will revert it. + /usr/local/bin/cmake --build /Users/buildnode/jenkins/workspace/oss-swift-incremental-RA-osx/buildbot_incremental/swift-macosx-x86_64 -- -j12 -v all swift-stdlib-macosx-x86_64 swift-stdlib-iphonesimulator-i386 swift-stdlib-iphonesimulator-x86_64 swift

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #549

2017-04-27 Thread Arnold Schwaighofer via swift-dev
IO exception: device disconnected > On Apr 27, 2017, at 12:04 AM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-ASAN-RA-osx [#549] > > Build URL:https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/549/ >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (swift 4.0) #272

2017-04-28 Thread Arnold Schwaighofer via swift-dev
The commit was already reverted by Akira in the swift-4.0-branch. > On Apr 28, 2017, at 1:30 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-4.0-incremental-RA-osx [#272] > > Build URL:https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/272/ >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #3338

2017-04-28 Thread Arnold Schwaighofer via swift-dev
This looks very much like the reoccurring cmake dependency issue where things are not getting rebuild. I started a clean workspace. /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_10/buildbot_incremental/foundation-linux-x86_64/TestFoundation/TestFoundation: symbol loo

Re: [swift-dev] [Swift CI] Build Still Failing: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #185

2017-04-30 Thread Arnold Schwaighofer via swift-dev
Thank you Mark! https://github.com/apple/swift/pull/9139 > On Apr 30, 2017, at 2:55 PM, Mark Lacey wrote: > > Ben / Robert, I bisected the failures here and it looks like they are due to > these two changes: > > > Robert, The XFAILed FP test that is now passing (and thus…failing) is due t

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #3440

2017-05-03 Thread Arnold Schwaighofer via swift-dev
Complaining about a missing symbol in Foundation. Historically these errors go away on a clean build. (There seems to be a missing cmake dependency) Test Case 'TestNSHTTPURLResponse.test_NSCoding' started at 2017-05-03 16:50:10.495 /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linu

Re: [swift-dev] question about performance of dispatches on existentials

2017-07-07 Thread Arnold Schwaighofer via swift-dev
This is a failure in the optimizer of identifying two loads to return the same value and so it can’t remove a retain/release pair. / protocol witness for B.foo(_:) in conformance OtherB sil shared [transparent] [serialized] [thunk] @_T04test6OtherBCAA1BA2aDP3fooyAA1ACFTW : $@convention(witness_

Re: [swift-dev] Debugging performance regressions?

2017-08-09 Thread Arnold Schwaighofer via swift-dev
Mark do you have suggestions for Dave? > On Aug 9, 2017, at 11:22 AM, David Zarzycki via swift-dev > wrote: > > Any tips on how to debug performance regressions? > > And as aside, if this test is critical enough to cause a revert, why isn’t it > in the public repo? > This is part of a large

Re: [swift-dev] [swift-users] Module verifier error with master branch

2017-08-30 Thread Arnold Schwaighofer via swift-dev
Can you file a bug at bugs.swift.org with a project/source file that reproduces the failure? > On Aug 29, 2017, at 4:20 PM, Raj Barik via swift-users > wrote: > > OS: 10.12.6 (16G29) > > Steps: > 1) Checkout swift and build master branch >git clone https://git

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #425

2017-09-06 Thread Arnold Schwaighofer via swift-dev
Cannot be related to my commit. I did however see this test failing intermittently. > On Sep 6, 2017, at 12:48 PM, Mishal Shah wrote: > > Test Case 'TestURLSession.test_concurrentRequests' started at 2017-09-06 > 19:43:55.444 > /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #425

2017-09-06 Thread Arnold Schwaighofer via swift-dev
For example, an the same failure occurred earlier here: https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/422/console > On Sep 6, 2017, at 12:54 PM, Arnold Schwaighofer > wrote: > > Cannot

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #443

2017-09-07 Thread Arnold Schwaighofer via swift-dev
Recovered in follow-up build. [ RUN ] Array.COW.Fast.RemoveAllDoesNotReallocate stdout>>> check failed at /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/swift/validation-test/stdlib/Arrays.swift.gyb, line 361 stdout>>> expected: 11 (of type Swift.Int) stdout>>

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #529

2017-09-13 Thread Arnold Schwaighofer via swift-dev
It looks like TestFoundation was not rebuild. The failing test has passed on incremental linux bots who rebuild TestFoundation. If the executable still references the removed array value witnesses I would not be surprised that it would fail. I suspect a clean build will make this test succeed. I

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #529

2017-09-13 Thread Arnold Schwaighofer via swift-dev
Looks like updating the module format number did not cause a rebuild of TestFoundation. Can you clean the workspace? > On Sep 13, 2017, at 9:30 AM, Ben Langmuir wrote: > > Thanks Arnold; if that doesn't do it I'll clean the workspace. > >> On Sep 13, 2017, at 8:57 AM, Arnold Schwaighofer >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #1339

2017-10-30 Thread Arnold Schwaighofer via swift-dev
It does not look like TestFoundation was rebuild which is definitely necessary after my change. A clean build and/or https://github.com/apple/swift/pull/12676 (Increase the version number after single payload enum change) hopefully fixes this. --- Finished tests for libdispatch --- --- Runnin

Re: [swift-dev] No attribute(swiftcall) support on Linux?

2017-11-14 Thread Arnold Schwaighofer via swift-dev
> On Nov 14, 2017, at 12:33 AM, Slava Pestov via swift-dev > wrote: > > This is while building the metadata unit tests — I’m assuming those are built > with the host clang? Do we build the runtime with the Swift clang on Linux? > If so, we should still be able to use swiftcall. Yes we buil

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 16.04 (master) #762

2017-11-28 Thread Arnold Schwaighofer via swift-dev
module map file '/home/buildnode/jenkins/workspace/oss-swift-package-linux-ubuntu-16_04/swift-corelibs-libdispatch/dispatch/module.modulemap' not found Those usually go away after a clean build? > On Nov 28, 2017, at 1:10 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-package-linux-ubu

[swift-dev] Swift Incremental broken

2017-11-28 Thread Arnold Schwaighofer via swift-dev
The incremental OS X bot is broken. Anyone has any ideas? Thanks! https://ci.swift.org/job/oss-swift-incremental-RA-osx/1586/ FAILURE EXECUTING SUBPROCESS command: /Users/buildnode/jenkins/workspace/oss-swift-incremental-

Re: [swift-dev] Swift Incremental broken

2017-11-29 Thread Arnold Schwaighofer via swift-dev
Looks like this is caused by https://github.com/apple/swift/pull/12952 <https://github.com/apple/swift/pull/12952>. Reverting here: https://github.com/apple/swift/pull/13144 > On Nov 28, 2017, at 9:30 PM, Arnold Schwaighofer via swift-dev > wrote: > > The incremental

Re: [swift-dev] Protocol Devirtualizer Pass

2017-11-29 Thread Arnold Schwaighofer via swift-dev
The issue I raised is when we truly replace the type in an existing function: protocol Proto :class {} class SingleImpl : Proto {} class User { func useProto(p: Proto) {} } If i understand you correctly your pass changes this program to: class User { func useProto(p: SingleImpl) {} }

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #1815

2017-11-30 Thread Arnold Schwaighofer via swift-dev
Could be an incremental build failure ... > On Nov 30, 2017, at 12:27 PM, Saleem Abdulrasool > wrote: > > Weird, this made it through multiple builds just fine. Either way, I believe > PR#13180 should repair the build. > ___ swift-dev mailing list

[swift-dev] Swift CI: oss-lldb-incremental-linux-ubuntu-16_04

2017-11-30 Thread Arnold Schwaighofer via swift-dev
I did not get a build email (or can't find it). Looks like: Clean up some unintended divergence between llvm.org and github lldb. broke: https://ci.swift.org/job/oss-lldb-incremental-linux-ubuntu-16_04/1618/ CMake Error at /home/buildnode/jenkins/workspace/oss-lldb-incremental-linux-ubuntu

Re: [swift-dev] Swift CI Hardware Update

2017-11-30 Thread Arnold Schwaighofer via swift-dev
Wohoo! On 11/30/17 04:31 PM, Mishal Shah via swift-dev wrote: > Swift CI Hardware Update: > > Additional pull request testing bots added to > ci.swift.org(http://ci.swift.org) > > - 15 additional macOS executors > > - 8 additional Ubuntu 16.04 executors _

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #838

2017-12-01 Thread Arnold Schwaighofer via swift-dev
Reverted. > On Dec 1, 2017, at 7:21 AM, no-re...@swift.org wrote: > > [FAILURE] swift-master-source-compat-suite [#838] > > Build URL:https://ci.swift.org/job/swift-master-source-compat-suite/838/ > > Project: swift-mas

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1789

2017-12-01 Thread Arnold Schwaighofer via swift-dev
16_10/buildbot_incremental/libdispatch-linux-x86_64/src/swiftDispatch.o <>:0: error: cannot open file '/home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_10/swift-corelibs-libdispatch/private/module.modulemap': No such file or directory They come and go ... > On Dec

Re: [swift-dev] Protocol Devirtualizer Pass

2017-12-13 Thread Arnold Schwaighofer via swift-dev
You don’t need a second open_existential_ref in the _wrap_inc function. It should look something like this: sil @_wrap_inc : $@convention(thin) (@owned T, Int) -> Int { bb0(%0 : $T, %1 : $Int): %5 = witness_method $T, #SumProtocol.inc!1 : (Self) -> (Int) -> Int : $@convention(witness_method

Re: [swift-dev] Swift CI "auto retry"?

2017-12-20 Thread Arnold Schwaighofer via swift-dev
This is caused by clang change 1ac71826854a809f67ae15ddacaaa9a6eb8189e8. This change was reverted on swift-4.1-branch. Merging clang's swift-4.1-branch into stable is blocked by another error that we can also see here: https://ci.swift.org/job/swift-PR-osx/2060/consoleFull#-12191974833122a513-f3

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (swift 4.1) #699

2018-01-16 Thread Arnold Schwaighofer via swift-dev
FATAL: Unable to produce a script file java.io.IOException: No space left on device > On Jan 16, 2018, at 9:35 AM, swift...@swift.org wrote: > > [FAILURE] oss-swift-4.1-incremental-RA-linux-ubuntu-16_04 [#699] > > Build URL: > https://ci.swift.org/job/oss-swift-4.1-incremental-RA-linux-u