Re: [swift-dev] Filename, Line and Column for SourceLoc

2017-03-20 Thread rintaro ishizaki via swift-dev
Thanks! I'd go with "presumed". I've just started a WIP pull request. https://github.com/apple/swift/pull/8203 2017-03-17 7:37 GMT+09:00 Ben Langmuir : > +1. The fact that APIs named “getLineNumber” and “getLineAndColumn” do > subtly different things is pretty awful. > > I like “presumed” bet

Re: [swift-dev] Filename, Line and Column for SourceLoc

2017-03-16 Thread Ben Langmuir via swift-dev
+1. The fact that APIs named “getLineNumber” and “getLineAndColumn” do subtly different things is pretty awful. I like “presumed” better than “virtual”, but it’s not a big deal to me either way. Ben > On Mar 16, 2017, at 3:20 PM, Jordan Rose via swift-dev > wrote: > > FWIW this sounds lik

Re: [swift-dev] Filename, Line and Column for SourceLoc

2017-03-16 Thread Jordan Rose via swift-dev
FWIW this sounds like a great idea to me. Clang calls these "presumed locations" instead of "virtual locations" but either way is fine with me. I'd like one of the SourceKit folks to weigh in, though, since they're the most involved in operations at this layer. (That'd be Argyrios Kyrtzidis, Ben

[swift-dev] Filename, Line and Column for SourceLoc

2017-03-15 Thread rintaro ishizaki via swift-dev
Hi all, I would like to propose to reorganize methods for retrieving filename, line and column from SourceLoc. *Motiavion* When we want to retrieve filename, line and column from SourceLoc, we have several ways to do that. Filename: SourceManager::getBufferIdentifierForLoc SourceManager::ge