Re: [swift-dev] Purpose of validation-test/Reflection/reflect_*.swift

2016-10-26 Thread Dave Abrahams via swift-dev
on Wed Oct 26 2016, Slava Pestov wrote: > The tests are there to ensure the reflection output doesn’t > accidentally break or change. Unless you have reason to think it will break or change *only* for some particular stdlib types, and that reflecting the implementation details of those types i

Re: [swift-dev] Purpose of validation-test/Reflection/reflect_*.swift

2016-10-26 Thread Slava Pestov via swift-dev
The tests are there to ensure the reflection output doesn’t accidentally break or change. However if you’re updating the layout of those types you need to update the tests. Slava > On Oct 26, 2016, at 5:41 PM, Michael Gottesman via swift-dev > wrote: > > >> On Oct 26, 2016, at 5:29 PM, Alex

Re: [swift-dev] Purpose of validation-test/Reflection/reflect_*.swift

2016-10-26 Thread Michael Gottesman via swift-dev
> On Oct 26, 2016, at 5:29 PM, Alexis via swift-dev wrote: > > I’m not clear on what the reflection tests are attempting to actually verify. > Just that we don’t change the internal layout of these types accidentally? > We’re churning up the layouts of a lot of the collections to get things al

[swift-dev] Purpose of validation-test/Reflection/reflect_*.swift

2016-10-26 Thread Alexis via swift-dev
I’m not clear on what the reflection tests are attempting to actually verify. Just that we don’t change the internal layout of these types accidentally? We’re churning up the layouts of a lot of the collections to get things all set up for ABI stability, which means mechanically updating these t