Re: [swift-dev] swift-format editor integration

2017-05-03 Thread Saleem Abdulrasool via swift-dev
On Tue, May 2, 2017 at 10:41 PM Ted Kremenek wrote: > On Apr 28, 2017, at 8:17 AM, Saleem Abdulrasool > wrote: > > Hi Ted, > > I think that what I'm proposing adding is quite small. It has a mirror > equivalent in the clang repository. > > > I thought about it more, and you convinced me. I’m f

Re: [swift-dev] swift-format editor integration

2017-05-02 Thread Ted Kremenek via swift-dev
> On Apr 28, 2017, at 8:17 AM, Saleem Abdulrasool wrote: > > Hi Ted, > > I think that what I'm proposing adding is quite small. It has a mirror > equivalent in the clang repository. I thought about it more, and you convinced me. I’m fine with taking it. Can you revise the description in PR

Re: [swift-dev] swift-format editor integration

2017-04-28 Thread Saleem Abdulrasool via swift-dev
Hi Ted, I think that what I'm proposing adding is quite small. It has a mirror equivalent in the clang repository. As to maintainence, I'm willing to take that on. I already maintain the vim syntax support (I'm pretty confident that I've made the bulk of the changes to it at this point). I'm n

Re: [swift-dev] swift-format editor integration

2017-04-27 Thread Ted Kremenek via swift-dev
Hi Saleem, My apologies for the delay. Generally speaking, doesn't feel to me that these kinds of enhancements should be going into the 'swift' repository. We have some basic support files for editors in the repository, but largely those are there for historical reasons (largely convenience w

[swift-dev] swift-format editor integration

2017-04-24 Thread Saleem Abdulrasool via swift-dev
Hi, Jordan asked me to check with you about adding a simple helper for integrating swift-format into vim since the repository hasn't really added any editor integration stuff previously. It's just a python wrapper for invoking swift-format (much like clang-format). It is on GitHub as PR8610. Th