Re: [swift-evolution] [Review] SE-0128: Change failable UnicodeScalar initializers to failable

+1 Makes sense, it's a basic failable conversion. On Fri, Jul 22, 2016 at 2:09 PM, 王 黎明 wrote: > +0. > > Maybe off topic. > > The problem is there’s no process for the validty of the parameter. > > The source of UnicodeScala: > > public init(_ v: UInt32) { > //

Re: [swift-evolution] [Review] SE-0128: Change failable UnicodeScalar initializers to failable

+1. I was trying to build a naive random string generator the other day (but I wanted it to occasionally spit out extended clusters like emojis), and was also surprised that the initialiser crashes. Could probably be filed under “bug fixes”, even. Karl > On 22 Jul 2016, at 00:28, Chris

Re: [swift-evolution] [Review] SE-0128: Change failable UnicodeScalar initializers to failable

+1. This is an obvious improvement and makes the API safer to use, and aligns with other string APIs (like those that decode UTF-8). On Thu, Jul 21, 2016 at 3:31 PM Xiaodi Wu via swift-evolution < swift-evolution@swift.org> wrote: > +1. Sensible change; addresses a real issue; proposed solution

Re: [swift-evolution] [Review] SE-0128: Change failable UnicodeScalar initializers to failable

+1. Sensible change; addresses a real issue; proposed solution is the one that most fits Swift best practices. On Thu, Jul 21, 2016 at 17:28 Chris Lattner via swift-evolution < swift-evolution@swift.org> wrote: > Hello Swift community, > > The review of "SE-0128: Change failable UnicodeScalar

[swift-evolution] [Review] SE-0128: Change failable UnicodeScalar initializers to failable

Hello Swift community, The review of "SE-0128: Change failable UnicodeScalar initializers to failable" begins now and runs through July 24. The proposal is available here: https://github.com/apple/swift-evolution/blob/master/proposals/0128-unicodescalar-failable-initializer.md Reviews