Re: [swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-12 Thread Jon Shier via swift-evolution
> What is your evaluation of the proposal? -1. There is a lot good here, but this feature is too important to let an “okay” proposal through. * Usage of the API doesn’t feel very Swifty, unless I’m missing some intended use case. Why are the encoders / decoders classes? Why do they have mutable

Re: [swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-12 Thread Douglas Gregor via swift-evolution
> On Apr 12, 2017, at 11:49 AM, Russ Bishop wrote: > > Doug, > > Would it be worth deferring this slightly since it relies on SE-0166? If > changes are made to SE-0166 as a result of review it will necessarily impact > this proposal. If there are changes to SE-0166 that

[swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-12 Thread Brad Hilton via swift-evolution
-1. I left my feedback for this proposal and SE-0166 on the other thread, but TLDR; I think this is premature until we add true reflection capabilities to Swift. > Hello Swift community, > > > The review of SE-0167 "Swift Encoders" begins now and runs through April 12, > 2017. The proposal is

Re: [swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-12 Thread Russ Bishop via swift-evolution
Doug, Would it be worth deferring this slightly since it relies on SE-0166? If changes are made to SE-0166 as a result of review it will necessarily impact this proposal. Russ Bishop > On Apr 6, 2017, at 11:10 AM, Douglas Gregor via swift-evolution > wrote: > >

Re: [swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-12 Thread Matthew Johnson via swift-evolution
Sent from my iPad > On Apr 12, 2017, at 2:53 AM, piotr gorzelany via swift-evolution > wrote: > > For me it boils down to a question if Data is the best type to represent > JSON. Data is really generic, you could serialize an UIImage into data and > pass it to

Re: [swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-12 Thread piotr gorzelany via swift-evolution
For me it boils down to a question if Data is the best type to represent JSON. Data is really generic, you could serialize an UIImage into data and pass it to the decoding function. Yes, JSON is not a very strong type but that is the nature of JSON, it is a dynamic data structure like a

Re: [swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-10 Thread Jordan Rose via swift-evolution
[Proposal: https://github.com/apple/swift-evolution/blob/master/proposals/0167-swift-encoders.md ] There's some pretty cool stuff in here. Nice work. I do have a few questions about this design, though: -

Re: [swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-10 Thread Matthew Johnson via swift-evolution
> On Apr 10, 2017, at 3:47 PM, Jordan Rose via swift-evolution > wrote: > > >> On Apr 10, 2017, at 02:52, David Hart via swift-evolution >> > wrote: >> >>> >>> On 10 Apr 2017, at 11:36, piotr gorzelany

Re: [swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-10 Thread Jordan Rose via swift-evolution
> On Apr 10, 2017, at 02:52, David Hart via swift-evolution > wrote: > >> >> On 10 Apr 2017, at 11:36, piotr gorzelany via swift-evolution >> > wrote: >> >> This is a really great proposal. As an iOS

Re: [swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-10 Thread David Hart via swift-evolution
> On 10 Apr 2017, at 11:36, piotr gorzelany via swift-evolution > wrote: > > This is a really great proposal. As an iOS developer I work with JSON almost > every day since most mobile apps communicate with a backend through JSON > messages. It's good to see that

[swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-10 Thread piotr gorzelany via swift-evolution
This is a really great proposal. As an iOS developer I work with JSON almost every day since most mobile apps communicate with a backend through JSON messages. It's good to see that better JSON support is coming to Foundation so we don't have to rely on third party libraries. That being said,

[swift-evolution] [Review] SE-0167: Swift Encoders

2017-04-06 Thread Douglas Gregor via swift-evolution
Hello Swift community, The review of SE-0167 "Swift Encoders" begins now and runs through April 12, 2017. The proposal is available here: https://github.com/apple/swift-evolution/blob/master/proposals/0167-swift-encoders.md Note that this proposal is closely related to (and dependent on)