Re: [swift-evolution] [swift-evolution-announce] [Review] SE-0118: Closure Parameter Names and Labels

2016-07-09 Thread Kevin Ballard via swift-evolution
On Tue, Jul 5, 2016, at 04:10 PM, Chris Lattner wrote: > * What is your evaluation of the proposal? Strong +1. Overall I like all of the changes listed in this proposal, with some commentary below. > lines.split(whereSeparator: isAllWhitespace) I think this is ok, but I'd also be fine wit

Re: [swift-evolution] [swift-evolution-announce] [Review] SE-0118: Closure Parameter Names and Labels

2016-07-08 Thread Erica Sadun via swift-evolution
On Jul 8, 2016, at 10:56 AM, Dave Abrahams wrote: > > > on Fri Jul 08 2016, Jordan Rose wrote: > This reads like an English sentence, but it doesn’t have the correct meaning for me. This implies a structure that has a pre-existing “separator", and checks if that separator matche

Re: [swift-evolution] [swift-evolution-announce] [Review] SE-0118: Closure Parameter Names and Labels

2016-07-08 Thread Dave Abrahams via swift-evolution
on Fri Jul 08 2016, Jordan Rose wrote: >>> This reads like an English sentence, but it doesn’t have the correct >>> meaning for me. This implies a structure that has a pre-existing >>> “separator", and checks if that separator matches the predicate, >>> rather than searching for an element that

Re: [swift-evolution] [swift-evolution-announce] [Review] SE-0118: Closure Parameter Names and Labels

2016-07-08 Thread Jordan Rose via swift-evolution
> On Jul 7, 2016, at 17:57, Dave Abrahams wrote: > > > on Thu Jul 07 2016, Jordan Rose > wrote: > >> [Proposal: >> https://github.com/apple/swift-evolution/blob/master/proposals/0118-closure-parameter-names-and-labels.md >> ] >> >> Hi, Dave, Dmitri, Max. Sorry I didn’

Re: [swift-evolution] [swift-evolution-announce] [Review] SE-0118: Closure Parameter Names and Labels

2016-07-07 Thread Dave Abrahams via swift-evolution
on Thu Jul 07 2016, Jordan Rose wrote: > [Proposal: > https://github.com/apple/swift-evolution/blob/master/proposals/0118-closure-parameter-names-and-labels.md > ] > > Hi, Dave, Dmitri, Max. Sorry I didn’t make the pre-review commentary > thread. I find I’m still not happy with several of thes

Re: [swift-evolution] [swift-evolution-announce] [Review] SE-0118: Closure Parameter Names and Labels

2016-07-07 Thread Erica Sadun via swift-evolution
> On Jul 7, 2016, at 5:03 PM, Jordan Rose via swift-evolution > wrote: > > [Proposal: > https://github.com/apple/swift-evolution/blob/master/proposals/0118-closure-parameter-names-and-labels.md > >

Re: [swift-evolution] [swift-evolution-announce] [Review] SE-0118: Closure Parameter Names and Labels

2016-07-07 Thread Jordan Rose via swift-evolution
[Proposal: https://github.com/apple/swift-evolution/blob/master/proposals/0118-closure-parameter-names-and-labels.md ] Hi, Dave, Dmitri, Max. Sorry I didn’t make the pre-review commentary thread. I find I’m still not happy with several of these names, although there are many other improvements