Re: [PATCH] 6179357-related: Working on warnings removal

2007-10-16 Thread Roman Kennke
Hi Ismael, > Roman Kennke <[EMAIL PROTECTED]> writes: > > This isn't exactly correct. The equivalent of a ReferenceQueue in > > generics notation is ReferenceQueue. See: > > I don't think there's an exact equivalent, but if you take a List as an > example > (because it has public methods that a

Re: [PATCH] 6179357-related: Working on warnings removal

2007-10-16 Thread Pavel Porvatov
Hi Roman, Hmm. It's copy.paste mistake:) This comment relatives to 2 . I meant: 1. DesktopProperty: Can You change declaration into private final static ReferenceQueue queue = new ReferenceQueue(); and remove a static section? 2. WindowsScrollBarUI: Can You change declaration into pr

Re: [PATCH] 6179357-related: Working on w arnings removal

2007-10-16 Thread Ismael Juma
Roman Kennke <[EMAIL PROTECTED]> writes: > This isn't exactly correct. The equivalent of a ReferenceQueue in > generics notation is ReferenceQueue. See: I don't think there's an exact equivalent, but if you take a List as an example (because it has public methods that accept the generic argument)

Re: [PATCH] 6179357-related: Working on warnings removal

2007-10-16 Thread Roman Kennke
Hi there, > 1. DesktopProperty: > Can You change declaration into > private final static ReferenceQueue queue = new > ReferenceQueue(); > (note that I added final and replaced HashMap by Map) and remove a > static section? This isn't exactly correct. The equivalent of a ReferenceQueue in gener

Re: [PATCH] 6179357-related: Working on warnings removal

2007-10-16 Thread Pavel Porvatov
Hi Florian, I like Your idea to clean code and I hope we will make it ASAP. I will be a reviewer of Your changes and at the end I will put Your changes into JDK. At the first I want to notify about couple things: 1. We are moving on mercurial (http://www.selenic.com/mercurial/wiki/) now and it