Re: [PATCH] GrayFilter cache

2008-04-29 Thread Roman Kennke
Hi, > > I'm not a swing developer, but I'd suggest to not use static field for > > cache, but have per-AppContext cache instead (due to security reasons) > > Whoops. I have to get used to that .. Improved patch attached. No more opinions on that? Cheers, Roman -- Dipl.-Inform. (FH) Roman Ke

hg: jdk7/swing/jdk: 6614972: JSlider value should not change on right-click

2008-04-29 Thread pavel . porvatov
Changeset: aaa771ded30b Author:rupashka Date: 2008-04-29 17:48 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/aaa771ded30b 6614972: JSlider value should not change on right-click Summary: WindowsSliderUI won't use the right mouse button for change slider position Reviewed

Re: [PATCH] 6179357-related: warnings removal in com.sun.java.swing.plaf.motif

2008-04-29 Thread Florian Brunner
Hi Pavel, Send me all remaining fixes at once. I changed my opinion because 1. I don't want to produce a lot of CRs for every part of fix 2. I'm going to do a small correction (if needed of course) in your fix myself. It'll save a lot of our time Ok, great, I will do that as soon as I find so

Re: [PATCH] 6179357-related: warnings removal in com.sun.java.swing.plaf.motif

2008-04-29 Thread Pavel Porvatov
Hi Florian, Hi Pavel! I've pushed your changes into http://hg.openjdk.java.net/jdk7/swing/jdk, changeset is here http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5b1734431fa5. Note that these changes can appear in http://hg.openjdk.java.net/jdk7/jdk7/jdk in June in the build 28 (have a look a

Re: [PATCH] 6179357-related: warnings removal in com.sun.java.swing.plaf.motif

2008-04-29 Thread Florian Brunner
Hi Pavel! I've pushed your changes into http://hg.openjdk.java.net/jdk7/swing/jdk, changeset is here http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5b1734431fa5. Note that these changes can appear in http://hg.openjdk.java.net/jdk7/jdk7/jdk in June in the build 28 (have a look at integration

Re: [PATCH] 6179357-related: warnings removal in com.sun.java.swing.plaf.motif

2008-04-29 Thread Pavel Porvatov
Hi Florian, I've pushed your changes into http://hg.openjdk.java.net/jdk7/swing/jdk, changeset is here http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5b1734431fa5. Note that these changes can appear in http://hg.openjdk.java.net/jdk7/jdk7/jdk in June in the build 28 (have a look at integration

hg: jdk7/swing/jdk: 6693507: There are unnecessary compilation warnings in the com.sun.java.swing.plaf.motif package

2008-04-29 Thread pavel . porvatov
Changeset: 5b1734431fa5 Author:rupashka Date: 2008-04-29 15:47 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/5b1734431fa5 6693507: There are unnecessary compilation warnings in the com.sun.java.swing.plaf.motif package Summary: Removed unnecessary castings and other warn

hg: jdk7/swing/jdk: 6210674: FileChooser fails to load custom harddrive icon and gets NullPointerException

2008-04-29 Thread pavel . porvatov
Changeset: 0447f9c7aed7 Author:rupashka Date: 2008-04-29 13:49 +0400 URL: http://hg.openjdk.java.net/jdk7/swing/jdk/rev/0447f9c7aed7 6210674: FileChooser fails to load custom harddrive icon and gets NullPointerException Summary: WindowsPlacesBar should use default icon for folders