Re: [8] Review request for 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx

2012-12-05 Thread Anthony Petrov
Thank you, Anton. The comment looks fine to me (and so does the fix). -- best regards, Anthony On 12/5/2012 8:53 PM, Anton Litvinov wrote: Hello Anthony, Thank you for the review of this fix. The corresponding comment was added to the bug's page. Unfortunately it is not available on the publi

Re: [8] Review request for 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx

2012-12-05 Thread Anton Litvinov
Hello Anthony, Thank you for the review of this fix. The corresponding comment was added to the bug's page. Unfortunately it is not available on the public bug report yet for the reason of synchronization delay. A copy of this comment is provided below. Comment: It was learnt that incomplete

Re: [8] Review request for 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx

2012-12-05 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 12/5/2012 1:33 PM, Anton Litvinov wrote: Hello, Please review the following fix for a bug. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003982 Webrev: http://cr.openjdk.java.net/~alitvinov/8003982/webrev.00 This bug consist

Re: [8] Review request for 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx

2012-12-05 Thread Anthony Petrov
Hi Alexander, This sounds reasonable. Thanks for the clarification. Could this evaluation be added as a comment to the bug report, so that it would be clear to anyone why the fix simply works around the problem rather than resolves the underlying issue? -- best regards, Anthony On 12/5/2012

Re: [8] Review request for 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx

2012-12-05 Thread Alexander Potochkin
Hello Anthony Hi Anton, This fix seems to resolve the test failure, but not the bug itself. Do you think it makes sense to investigate why the Mac OS X L&F isn't serializable, and perhaps make it serializable so that the test passes w/o any modifications? Let me answer this question. It i

Re: [8] Review request for 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx

2012-12-05 Thread Anthony Petrov
Hi Anton, This fix seems to resolve the test failure, but not the bug itself. Do you think it makes sense to investigate why the Mac OS X L&F isn't serializable, and perhaps make it serializable so that the test passes w/o any modifications? -- best regards, Anthony On 12/5/2012 1:33 PM, An

[8] Review request for 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx

2012-12-05 Thread Anton Litvinov
Hello, Please review the following fix for a bug. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003982 Webrev: http://cr.openjdk.java.net/~alitvinov/8003982/webrev.00 This bug consists in malfunctioning of serialization mechanism for Swing components in "Mac OS X" look and feel (L&F