Re: [8] Review request for 8013370: Null pointer exception when adding more than 9 accelators to a JMenuBar

Hi, Sergey. Looks like copyright header is incorrect in the test. On 03.06.2013 20:10, sergey malenkov wrote: Hello, Could you please review the following fix: fix: http://cr.openjdk.java.net/~malenkov/8013370.8.0 bug: http://bugs.sun.com/

[8] Review request for 8013370: Null pointer exception when adding more than 9 accelators to a JMenuBar

Hello, Could you please review the following fix: fix: http://cr.openjdk.java.net/~malenkov/8013370.8.0 bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013370 This is a regression after the 6680988fix. Note, that it is regression

Re: [7u] Review request for 7068740: If you wrap a JTable in a JLayer you can't use the page up and page down cmds

The fix looks good for me. Thanks, Alexandr. On 6/3/2013 5:53 PM, Vladislav Karnaukhov wrote: Hello, could you please review a request for a backport into jdk7? The fix is identical to that in jdk8. webrev: http://cr.openjdk.java.net/~vkarnauk/7068740/jdk7/webrev.00/ jdk8 changeset:

Re: [7u] Review request for 8014863 Line break calculations in Java 7 are incorrect

The fix looks good for me. Thanks, Alexandr. On 6/3/2013 4:09 PM, dmitry markov wrote: Hi Alexandr, I have just tested the fix. The tests are passed. Thanks, Dmitry On 03/06/2013 13:39, Alexander Scherbatiy wrote: Could you test your fix with the Notepad and Stylepad demos and ru

[7u] Review request for 7068740: If you wrap a JTable in a JLayer you can't use the page up and page down cmds

Hello, could you please review a request for a backport into jdk7? The fix is identical to that in jdk8. webrev: http://cr.openjdk.java.net/~vkarnauk/7068740/jdk7/webrev.00/ jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a4356b90f57d Regards, - Vlad

Re: [7u] Review request for 8014863 Line break calculations in Java 7 are incorrect

Hi Alexandr, I have just tested the fix. The tests are passed. Thanks, Dmitry On 03/06/2013 13:39, Alexander Scherbatiy wrote: Could you test your fix with the Notepad and Stylepad demos and run the regression tests: jdk\test\javax\swing\text Thanks, Alexandr. On 6/3/2013 1:0

Re: [7u] Review request for 6436314: Vector could be created with appropriate size in DefaultComboBoxModel

The fix looks good for me. On 6/3/2013 3:04 PM, Vladislav Karnaukhov wrote: Hello, please review a request for simple backport into jdk7. webrev: http://cr.openjdk.java.net/~vkarnauk/6436314/jdk7/webrev.00/ jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/791fd2ef87b3 The fix is

Re: [8] Review request for 6337518: Null Arrow Button Throws Exception in BasicComboBoxUI

The fix looks good for me. Thanks, Alexandr. On 6/2/2013 1:56 PM, Anton Litvinov wrote: Hello Alexander, Thank you for the review of this fix. Could you please review a new version of the fix, which was changed according to your remarks. The file name of the regression test was change

[7u] Review request for 6436314: Vector could be created with appropriate size in DefaultComboBoxModel

Hello, please review a request for simple backport into jdk7. webrev: http://cr.openjdk.java.net/~vkarnauk/6436314/jdk7/webrev.00/ jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/791fd2ef87b3 The fix is identical to that in jdk8. Regards, - Vlad

Re: [8] Review request for 7151823: The test incorrectly recognizing OS

Hello Alexander, Thank you for the review of this fix and information about "hitMnemonics()" method from the class "Util.java". Yes, surely, the next time when I need to press mnemonic keys using "java.awt.Robot" I will use this method. I supposed that in this particular bug, I had just to co

Re: [8] Review request for 7151823: The test incorrectly recognizing OS

The fix looks good for me. Next time you could use hitMnemonics() method form the swing regtesthelpers Util class that uses system mnemonics keys. Thanks, Alexandr. On 6/2/2013 1:30 PM, Anton Litvinov wrote: Hello, Please review the following fix for the bug. Bug: http://bugs.sun.com/

Re: [7u] Review request for 8014863 Line break calculations in Java 7 are incorrect

Could you test your fix with the Notepad and Stylepad demos and run the regression tests: jdk\test\javax\swing\text Thanks, Alexandr. On 6/3/2013 1:09 PM, dmitry markov wrote: Hello, Please review the back-port of the fix for 8014863 to jdk7u. I have changed the fix for jdk7u,

Re: [7u] Review request for 8014863 Line break calculations in Java 7 are incorrect

Hello, Please review the back-port of the fix for 8014863 to jdk7u. I have changed the fix for jdk7u, corrected the calculation of the variable 'index1' to prevent an IndexOutOfBoundsException. New webrev is located at http://cr.openjdk.java.net/~alitvinov/8014863/webrev.01 bug: http://bugs.

Re: [8] Review request for 7151823: The test incorrectly recognizing OS

Looks good! Thanks alexp On 6/2/2013 1:30 PM, Anton Litvinov wrote: Hello, Please review the following fix for the bug. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151823 Webrev: http://cr.openjdk.java.net/~alitvinov/7151823/webrev.00 The bug consists in the fact that a regress

Re: [8] Review request for 6337518: Null Arrow Button Throws Exception in BasicComboBoxUI

Hello Anton On 6/2/2013 1:56 PM, Anton Litvinov wrote: Hello Alexander, Thank you for the review of this fix. Could you please review a new version of the fix, which was changed according to your remarks. The file name of the regression test was changed to "bug6337518.java" and the test was