Re: [9] Review request for 7094099: DropDown List of JComboBox detached

Hi Sergey, The listener here is intended for the AppContext whole lifecycle and should not be removed until AppContext is disposed. Just picked this up from usages of other AppContext keys. As far as I understand StringBuffer is used instead of String for security reasons: AppContext u

Re: [9] Review request for 7094099: DropDown List of JComboBox detached

Hi, Anton. When this listener should be cleaned? Why StringBuffer is used as a key? On 2/14/14 7:27 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/7094099/9/webrev.00/

Re: [9] Review request for 8008657 JSpinner setComponentOrientation doesn't affect on text orientation

Hi, Alexander. The fix looks good. But can you please add a comment to the constructor of NumberEditor... where we set default alignment of text component to JTextField.RIGHT. On 2/14/14 2:50 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix? Thanks, Alexandr. On 1/24/

Re: [9] Review request for 7094099: DropDown List of JComboBox detached

Hello Anton Looks good to me! Thanks alexp On 2/14/2014 7:27 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/7094099/9/webrev.00/ bug: https://bugs.openj

[9] Review request for 7094099: DropDown List of JComboBox detached

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/7094099/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-7094099 This is the open part of the whole fix which adds a hook to t

Re: [9] Review request for 8008657 JSpinner setComponentOrientation doesn't affect on text orientation

The fix looks good for me. SAM On 14.02.2014 14:50, Alexander Scherbatiy wrote: Hello, Could you review the fix? Thanks, Alexandr. On 1/24/2014 2:14 PM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8008657/webrev.02/ The

Re: [9] Review request for 8008657 JSpinner setComponentOrientation doesn't affect on text orientation

Hello, Could you review the fix? Thanks, Alexandr. On 1/24/2014 2:14 PM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8008657/webrev.02/ The applyComponentOrientation() method is only invoked for the spinner editor. On 1

Re: [9] RFR 8034164: Introspector ignores indexed part of the property sometimes

The fix looks good for me. Thanks, Alexandr. On 2/13/2014 2:39 PM, sergey malenkov wrote: Hello, Could you please review the following fix: fix: http://cr.openjdk.java.net/~malenkov/8034164.9.0/ bug: https://bugs.openjdk.java.net/browse/JDK-8034164 The regression test checks for all co