Re: [9] Review Request: JDK-8032878: Editable combos in table do not behave as expected

2014-03-17 Thread Alexander Scherbatiy
The fix looks good for me. On 3/17/2014 5:32 PM, Alexey Ivanov wrote: Hi Alexandr, I've corrected the condition, please find the updated webrev at http://cr.openjdk.java.net/~dmarkov/8032878/jdk9/webrev.01/ - You're right! T

Re: [9] Review Request: JDK-8032878: Editable combos in table do not behave as expected

2014-03-17 Thread Alexey Ivanov
Hi Alexandr, I've corrected the condition, please find the updated webrev at http://cr.openjdk.java.net/~dmarkov/8032878/jdk9/webrev.01/ - You're right! The correct condition must have been !Boolean.TRUE.equals(getClientProperty(

Re: [9] Review Request: JDK-8032878: Editable combos in table do not behave as expected

2014-03-17 Thread Alexander Scherbatiy
- It seems that the "JComboBox.isTableCellEditor" client property can have null value which should be treated as false but it does not pass the check Boolean.FALSE.equals(null). - I am not able to use arrows during JComboBox editing because it moves the focus to another component.