Re: JDK 9 RFR of JDK-8039860: Fix fallthrough lint warnings in swing

2014-04-22 Thread Joe Darcy
Pushed with recommended changes to the code; thanks for the review, -Joe On 04/09/2014 07:33 PM, Joe Darcy wrote: Hello, Please review the changes below to address JDK-8039860: Fix fallthrough lint warnings in swing http://cr.openjdk.java.net/~darcy/8039860.0/ In many cases, there is

[9] Review request for 8036819, JAB: mnemonics not read for textboxes

2014-04-22 Thread Vivi An
Hello, Could you please review the fix for JDK 9? This bug is JAB related. Mnemonics not read for textbox. Fix made uses the available (linked) JLabel in JComponent to get available accessible key binding info. Bug: https://bugs.openjdk.java.net/browse/JDK-8036819 Webrev: http://cr.openjdk.

Re: [9] RFR 8039464: The scrollbar in JScrollPane has no right border if used WindowsLookAndFeel

2014-04-22 Thread sergey malenkov
Could you please review the second version of the fix: http://cr.openjdk.java.net/~malenkov/8039464.9.1/ It supports switching between Windows Themes. Note that the minimal thumb size for the horizontal scrollbar differs from the minimal thumb size for the vertical scrollbar. SAM On 21.04.2014 2

Re: [9] RFR 8039464: The scrollbar in JScrollPane has no right border if used WindowsLookAndFeel

2014-04-22 Thread Alexander Scherbatiy
The fix looks good for me. Could you add to the test pass criteria that the thumb should not vanish? Thanks, Alexandr. On 4/21/2014 9:04 PM, sergey malenkov wrote: Hello, Could you please review the following fix: http://cr.openjdk.java.net/~malenkov/8039464.9.0/ http://bugs.openjdk.java

Re: Review Request for 8040893: fix doclint block tag issues in swing border classes

2014-04-22 Thread Alexander Scherbatiy
On 4/21/2014 11:54 PM, Steve Sides wrote: On 4/21/2014 2:45 AM, Alexander Scherbatiy wrote: Hello Steve, /** * Returns the type of the bevel border. + * + * @return 0 if the bevel type is {@code RAISED}, 1 if {@code LOWERED} */ -