On 6/19/2014 12:17 AM, Petr Pchelko wrote:
Hello, Steve.
A couple of comments:
1. CellRendererPane:192 - I've never seen that we write one-liner javadoc.
May be it's better to split it into 3 lines to conform to the common
pattern?
I think I borrowed that from existing in JFrame. I put i
This has just this one change (duplicate 'if'),
http://cr.openjdk.java.net/~ssides/8042284/8042284.3/
-steve
On 6/19/2014 6:11 AM, Alexander Scherbatiy wrote:
-
src/share/classes/javax/swing/plaf/TreeUI.java
+ * @return true if {@code tree} if is being edited
*/
On 6/19/2014 5:57 AM, Alexander Scherbatiy wrote:
On 6/5/2014 9:58 PM, Steve Sides wrote:
While adding @param and @return to various swing files, I came across
this. The javadoc descriptions for
javax.swing.plaf.TreeUI.getPathBounds() and
javax.swing.plaf.basic.BasicTreeUI.getPathBounds() ha
Thanks!
On 19.06.2014 18:32, Alexander Scherbatiy wrote:
The fix looks good for me.
Thanks,
Alexandr.
On 6/16/2014 3:45 PM, alexander stepanov wrote:
Hello,
Could you please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8046445
Webrev corresponding:
h
The fix looks good to me.
Thanks,
Alexandr.
On 6/20/2014 10:26 AM, Dmitriy Ermashov wrote:
On 06/19/2014 06:39 PM, Petr Pchelko wrote:
Hello, Dmitriy.
It's impossible to review))
Impossible is nothing! (c))
I've briefly skimmed the classes and didn't see any problems with the
tests. Loo
Hi,
Do you have the number of the issue?
All client issues should be fixed in JDK 9 first.
You need to use the http://hg.openjdk.java.net/jdk9/client repository to
build your fix and create a patch.
Please, use the webrev tool to create a patch for the fix.
http://openjdk.java.net/guide/we
Hi!
I have at
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2014-June/028300.html
posted a patch of the MetalScrollBarUI. If you want, I will post it here again.
Please upload the patch!
Here is a screenshot, what the patch do:
http://s1.directupload.net/images/140620/2y7jlt6z.png
Greatin
