*ping*
Any other comments here?
Thanks,
-Joe
On 08/07/2014 07:20 PM, Joe Darcy wrote:
Hello,
Please review my changes for
JDK-8054360: Refine generification of javax.swing h
http://cr.openjdk.java.net/~darcy/8054360.3/
Full patch below.
This resolves many of the source incompatibility
Thank you, Alex.
On 8/12/2014 4:59 PM, Alexander Potochkin wrote:
Looks good!
Thanks
alexp
On 8/11/2014 11:39 AM, artem malinko wrote:
Hello again. Could somebody else join to the review please?
On 8/7/2014 6:21 PM, artem malinko wrote:
Thank you, Alexandr.
> The link to the webrev points
Looks good!
Thanks
alexp
On 8/11/2014 11:39 AM, artem malinko wrote:
Hello again. Could somebody else join to the review please?
On 8/7/2014 6:21 PM, artem malinko wrote:
Thank you, Alexandr.
> The link to the webrev points to the 8047288 fix instead of 8042835
Sorry, some weird copy and pas
No TAB, no \r, and no trailing space are hard requirements enforced by jcheck.
Otherwise it's only styles, including 4-space-indentation. "{" at the end of a
line, 8-space wrap indentation...
--Max (an Oracle dev)
On Aug 12, 2014, at 15:48, Andrej Golovnin wrote:
> As far as I know we should
> In the class
> src/share/classes/javax/management/openmbean/CompositeType.java you have
> added the
> annotation @SuppressWarnings("StringConcatenationInsideStringBufferAppend")
> instead of fixing the concatenation inside the append method. Why?
+1 Moreover, I wonder where this value comes from
Otavio,
Just skimmed through your changes. It looks good. But there are some things we
can make a little bit better though. IMO, it's not always a performance that
matters (looking around to see if Alexey Shipilev is somewhere near) but
readability. It's good to estimate performance requirement
Hi Otávio,
I think you should fix the indentation in a lot of classes. You use the
tab-character for the indentation. As far as I know we should use the space
character for the indentation in the JDK sources (Oracle devs feel free to
correct me if I'm wrong. And it would be really nice if the styl
