JDK 9 RFR of JDK-8055059: JDK9b22 public API exposes package private classes

2014-08-18 Thread Joe Darcy
Hello, Please review my proposed changes to address: JDK-8055059: JDK9b22 public API exposes package private classes http://cr.openjdk.java.net/~darcy/8055059.0/ Bug JDK-8055059 that the generification of swing added package-private types to the signatures of several protected methods.

[9] Review Request: 6329748 Invalid/old variable name - newModel in setModel method in JTable class

2014-08-18 Thread Sergey Bylokhov
Hello. Please review the small fix for jdk 9. Bug description: Long long time ago all our JTable.set*model methods used newModel as a parameter. Since then: - setModel() parameterand@param tag were changed from newModel to dataModel, but method description and @exception were not updated. - s

Re: [9] Review Request: 8049346 fix the @run line of the test: jdk/test/java/awt/Focus/SortingFTP/JDK8048887.java

2014-08-18 Thread Sergey Bylokhov
Hi, Anton. The fix looks good. On 04.07.2014 17:45, Anton V. Tarasov wrote: Hello, Please, review a fix of the reg test for JDK-8048887, where I put a wrong bugid into the @run tag: bug: https://bugs.openjdk.java.net/browse/JDK-8049346 webrev: http://cr.openjdk.java.net/~ant/JDK-8049346/webr

Re: JDK 9 RFR of JDK-8055254: Address source incompatability of JSlider generification

2014-08-18 Thread Anthony Petrov
+1 -- best regards, Anthony On 8/18/2014 2:27 PM, Sergey Bylokhov wrote: Hi, Joe. The fix looks good. On 18.08.2014 2:53, Joe Darcy wrote: Hello, As noted by Sergey, the recently pushed changes for JDK-8054360: Refine generification of javax.swing cause one of the files in SwingSet2 to

Re: JDK 9 RFR of JDK-8055254: Address source incompatability of JSlider generification

2014-08-18 Thread Sergey Bylokhov
Hi, Joe. The fix looks good. On 18.08.2014 2:53, Joe Darcy wrote: Hello, As noted by Sergey, the recently pushed changes for JDK-8054360: Refine generification of javax.swing cause one of the files in SwingSet2 to not build, breaking the combined open + closed JDK build. To remedy this

Re: [9] Review request for 8048110: Using tables in JTextPane leads to infinite loop in FlowLayout.layoutRow

2014-08-18 Thread dmitry markov
Hello Sergey, LogicalView.forwardUpdate() sends update event to all views followed by the changed place. This event will cause view to drop the cache and re-calculate its break points. This method was added under JDK-8024395 and intended for t