Re: Replace concat String to append in StringBuilder parameters

I found an error: diff --git a/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java b/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java --- a/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java +++ b/src/jdk.dev/share/classes/com/sun/tools/hat/int

Re: Replace concat String to append in StringBuilder parameters

Webrev updated again, this time include more changes. http://cr.openjdk.java.net/~weijun/8055723/client/webrev.02/ http://cr.openjdk.java.net/~weijun/8055723/core/webrev.02/ The change to a demo file is removed because that file itself is already removed. *Otávio*: I believe Andrej's follow

Re: JVM crash on Linux: program 'java' received an X Window System error RenderBadPicture when invoking UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel");

On Tue, Aug 26, 2014 at 12:49 PM, Alexander Scherbatiy < alexandr.scherba...@oracle.com> wrote: Could you file a bug on it: http://bugreport.java.com/bugreport ? I did (48h ago), and so far only got an auto-response saying "We are evaluating this report and have stored this with an Review ID:

Re: Replace concat String to append in StringBuilder parameters

I see no problem from the core part of the webrev. However, I am not sure how you find all the occurrences of "+" in StringBuilder, but I just run the following command in jdk/src find . -type f -name *.java -print | xargs grep -n StringBuilder | perl -ne 'print if /new StringBuilder\([^\)]*\

Re: Replace concat String to append in StringBuilder parameters

Hi all, src/java.base/share/classes/com/sun/crypto/provider/DHPublicKey.java: 269 .append(LINE_SEP + "g:" + LINE_SEP) should be changed to: 269 .append(LINE_SEP).append( "g:").append(LINE_SEP) src/java.base/share/classes/sun/security/x509/PolicyInformation.java:

Re: JVM crash on Linux: program 'java' received an X Window System error RenderBadPicture when invoking UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel");

Hi Michael, Could you file a bug on it: http://bugreport.java.com/bugreport ? Thanks, Alexandr. On 8/24/2014 1:09 AM, Michael Vorburger wrote: Hello OpenJDK Swing team (I am NOT subscribed to the swing-dev@openjdk.java.net list; could you please rep

Re: Review Request for 8055360: Move the rest part of AWT ShapedAndTranslucent tests to OpenJDK

The fix looks good to me. Thanks, Alexandr. On 8/22/2014 12:38 PM, Dmitriy Ermashov wrote: Hi Swing team, Please review one more part of functional tests being moved to OpenJDK. It is a swing part of AWT_ShapedAndTranslucent tests. http://cr.openjdk.java.net/~dermashov/8055360/webrev.00

Re: [9] Review Request: 6329748 Invalid/old variable name - newModel in setModel method in JTable class

The fix look good to me. Thanks, Alexandr. On 8/18/2014 6:18 PM, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk 9. Bug description: Long long time ago all our JTable.set*model methods used newModel as a parameter. Since then: - setModel() parameterand@param tag were

Re: [9] Review request for 8048110: Using tables in JTextPane leads to infinite loop in FlowLayout.layoutRow

- The fix sends an update event to all views followed by the changed place only if the first updated view is GlyphView. Should the GlyphViews be updated if the first view is not the GlyphView? - The javadoc for forwardUpdate() methods says: "If there were changes to the element this

Re: Replace concat String to append in StringBuilder parameters

Pavel, thanks for the checking and confirm. Look back to the benchmark code: private StringBuilder createBuilder(String... values) { StringBuilder text = new StringBuilder(); text.append(values[0]).append(values[1]) .append(values[2]).append(values[3]) .append(values[4]).append(va

Re: Replace concat String to append in StringBuilder parameters

It's exactly the way it's been working since 1.6 I believe. public class Optimization { public String concat(String... strings) { return "#: " + strings[0] + strings[2] + strings[3] + "..."; } } public class Optimization { public Optimization(); Code: 0: aload_0

Re: Replace concat String to append in StringBuilder parameters

I was wondering, is it nice to address it in Java compiler to use string builder for the string "+" operator? Xuelei On 8/26/2014 11:28 AM, Wang Weijun wrote: > New webrevs available at > > http://cr.openjdk.java.net/~weijun/8055723/client/webrev.01/ > http://cr.openjdk.java.net/~weijun/805