Re: [7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

2014-08-28 Thread Alexander Potochkin
The fix looks fine Thanks alexp On 8/28/2014 11:29 AM, Alexey Ivanov wrote: Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.openjdk.java.net/~aivanov/8056156/jdk7/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JD

Re: Possible new project: OpenJDK LaF

2014-08-28 Thread Mario Torre
On Wed, 2014-08-27 at 17:03 +0100, Martijn Verburg wrote: > I think a move to GTK 3 would eliminate a class of java/Linux desktop > issues we run across today. My concern would be the long term maintenance > of this piece... Yeah, long term maintenance will surely be some overhead, like anything t

Re: Replace concat String to append in StringBuilder parameters

2014-08-28 Thread Ivan Gerasimov
On 28.08.2014 3:15, Wang Weijun wrote: OK, I'll remember that. Thanks. So you will include the StringBuilder changes into your fix? No. I reimplemented MimeEntry.toProperty() with StringJoiner: http://hg.openjdk.java.net/jdk9/dev/jdk/diff/8be081fb8db1/src/java.base/share/classes/sun/net/ww

Re: Possible new project: OpenJDK LaF

2014-08-28 Thread Martijn Verburg
I think a move to GTK 3 would eliminate a class of java/Linux desktop issues we run across today. My concern would be the long term maintenance of this piece... On Wednesday, 27 August 2014, Mario Torre wrote: > Hi all, > > First of all, sorry for cross posting... I would like to kindly ask to >

Re: Replace concat String to append in StringBuilder parameters

2014-08-28 Thread Ivan Gerasimov
Hi Max! The core part is updated again at http://cr.openjdk.java.net/~weijun/8055723/core/webrev.03/ Can you please revert changes to src/java.base/share/classes/sun/net/www/MimeEntry.java, as they're conflicting with the fix for JDK-8054714? Apologizing for adding you more work. Sinc

Re: [7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

2014-08-28 Thread Seán Coffey
Approved. regards, Sean. On 28/08/2014 08:30, Anthony Petrov wrote: Hi Alexey, The fix looks fine. -- best regards, Anthony On 8/28/2014 11:29 AM, Alexey Ivanov wrote: Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.

Re: [7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

2014-08-28 Thread Anthony Petrov
Hi Alexey, The fix looks fine. -- best regards, Anthony On 8/28/2014 11:29 AM, Alexey Ivanov wrote: Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.openjdk.java.net/~aivanov/8056156/jdk7/webrev.00/ JBS: https://bugs.

[7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

2014-08-28 Thread Alexey Ivanov
Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.openjdk.java.net/~aivanov/8056156/jdk7/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8056156 Description: The test fails to compile under jdk7 because of lambda e