Re: [9] Review request for 8057770: api/javax_swing/JScrollPane/indexTGF.html#UpdateUI failed with MotifLookAndFeel on all platform

2014-09-09 Thread Sergey Bylokhov
Hi, Alexander. The fix looks good. On 09.09.2014 14:51, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8057770/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8057770 This issue MotifScrollPaneUI does not override uninstallListen

Re: [9] Review request for 8057770: api/javax_swing/JScrollPane/indexTGF.html#UpdateUI failed with MotifLookAndFeel on all platform

2014-09-09 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/9/2014 2:51 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8057770/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8057770 This issue MotifScrollPaneUI does not override unin

[9] Review request for 8057770: api/javax_swing/JScrollPane/indexTGF.html#UpdateUI failed with MotifLookAndFeel on all platform

2014-09-09 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8057770/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8057770 This issue MotifScrollPaneUI does not override uninstallListeners() method from BasicScrollPaneUI It has following signature protected void unins

Re: [9] Review request for 8048110: Using tables in JTextPane leads to infinite loop in FlowLayout.layoutRow

2014-09-09 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/9/2014 1:53 PM, dmitry markov wrote: Hi Alexandr, I have added updateAfterChange() method as you suggested. New version is located at http://cr.openjdk.java.net/~dmarkov/8048110/jdk9/webrev.03/ Thanks, Dmitry On 08/09/2014 14:44, Alexa

Re: [9] Review request for 8048110: Using tables in JTextPane leads to infinite loop in FlowLayout.layoutRow

2014-09-09 Thread dmitry markov
Hi Alexandr, I have added updateAfterChange() method as you suggested. New version is located at http://cr.openjdk.java.net/~dmarkov/8048110/jdk9/webrev.03/ Thanks, Dmitry On 08/09/2014 14:44, Alexander Scherbatiy wrote: On 8/27/2014 2:44 PM, dmitry markov wrote: Hello Alexandr, Thank you f

Re: [9] Review Request: 8057819 No CCC approving removing final modifier from javax.swing.SwingUtilities.isRectangleContainingRectangle static method

2014-09-09 Thread Alexander Zvegintsev
The fix looks good to me too. Thanks, Alexander. On 09/09/2014 12:47 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 9/8/2014 9:49 PM, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk 9. Part of the JDK-8046595 was reverted. Bug: https

Re: [9] Review Request: 8057819 No CCC approving removing final modifier from javax.swing.SwingUtilities.isRectangleContainingRectangle static method

2014-09-09 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/8/2014 9:49 PM, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk 9. Part of the JDK-8046595 was reverted. Bug: https://bugs.openjdk.java.net/browse/JDK-8057819 Webrev can be found at: http://cr.openjdk.java.net/~serb/805