Thank you Alexander,
New patch with fix:
http://cr.openjdk.java.net/~van/8033699/webrev.08/
Regards,
Vivi
On 10/8/2014 11:36 AM, Alexander Zvegintsev wrote:
Hello Vivi,
getFocusTransferBaseComponent():
Window parentWnd = SwingUtilities.getWindowAncestor((Component)
activeBtn);
Hello Vivi,
getFocusTransferBaseComponent():
Window parentWnd = SwingUtilities.getWindowAncestor((Component)
activeBtn);
if (parentWnd instanceof Container) {
Container container = (Container)parentWnd;
Window extending Container class, hence there is no
The fix looks good to me.
Could you also test the fix with the JCK and regression tests?
Thanks,
Alexandr.
On 10/8/2014 2:08 PM, dmitry markov wrote:
Hi Alexandr,
Thank you for the review.
HTMLDocument does not override getLength() method, so
AbstractDocument.getLength() is used. A
Hello Swing team,
Could you please review the fix for the bug:
bug: https://bugs.openjdk.java.net/browse/JDK-7170310
webrev: http://cr.openjdk.java.net/~aivanov/7170310/jdk9/webrev.0/
Description:
If you add more tabs to JTabbedPane than a frame can fit, scrolling
buttons are not enable
Hi Alexandr,
Thank you for the review.
HTMLDocument does not override getLength() method, so
AbstractDocument.getLength() is used. AbstractDocument.getLength()
returns one less than the length of the Content (see Java Docs for more
details). So if we add anything to the end of the document, w
The fix looks good to me.
Thanks,
Alexandr.
On 10/7/2014 5:25 PM, Sergey Bylokhov wrote:
Hi, Alexander.
The fix looks good.
On 07.10.2014 17:13, Alexander Zvegintsev wrote:
Hello,
please review a simple doc change:
https://bugs.openjdk.java.net/browse/JDK-8059297
http://cr.openjdk.java.n
On 10/8/2014 10:32 AM, dmitry markov wrote:
Hello,
Any volunteers to review the fix?
Could you give more details about the change:
-
-if (offset > getLength()) {
+if (offset > (getLength() + 1)) {
offset--;
}
---
