Re: Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

Yes, He did. On Thu, Dec 4, 2014 at 1:20 AM, Wang Weijun wrote: > > > > On Dec 3, 2014, at 22:47, Sergey Bylokhov > wrote: > > > > Hello. > > On 03.12.2014 17:40, Wang Weijun wrote: > >> Thanks for reviewing the codes. I am the sponsor for this bug. Do you > think it's OK for me to push the cha

Re: Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

> > On Dec 3, 2014, at 22:47, Sergey Bylokhov wrote: > > Hello. > On 03.12.2014 17:40, Wang Weijun wrote: >> Thanks for reviewing the codes. I am the sponsor for this bug. Do you think >> it's OK for me to push the changes for java.desktop to jdk9/dev/jdk? You didn't answer the question above,

Re: JDK 9 RFR of JDK-8055059: JDK9b22 public API exposes package private classes

Hi Petr, On 11/25/2014 12:50 AM, Petr Pchelko wrote: Hello, Joe. The fix looks good. With best regards. Petr. Thanks for the review. While I wouldn't mind pushing this version, Phil and Anthony previously raised concerns that these types shouldn't be exposed at all: http://mail.openjdk.j

Re: Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

Hi Sergey Thanks for reviewing the codes. I am the sponsor for this bug. Do you think it's OK for me to push the changes for java.desktop to jdk9/dev/jdk? Otherwise, can I push to jdk9/client/jdk myself or do I need to find someone in your group doing it? I am on the corelibs side and has only

Re: Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

Hello. On 03.12.2014 17:40, Wang Weijun wrote: Thanks for reviewing the codes. I am the sponsor for this bug. Do you think it's OK for me to push the changes for java.desktop to jdk9/dev/jdk? Otherwise, can I push to jdk9/client/jdk myself Yes, you can push it yourself to the jdk9/client/jdk

Re: Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

Hello, The changes in java.desktop looks good. On 18.11.2014 11:58, Otávio Gonçalves de Santana wrote: BUGURL: https://bugs.openjdk.java.net/browse/JDK-8055723 WEBREV: http://cr.openjdk.java.net/~weijun/8055723/webrev.01/ -- Otávio Go

Re: [9] Review request for 8066142 closed/javax/swing/JComboBox/4212498/bug4212498.java:Edit the value in the text field and then press the tab key, the number don't increase

Hello Alexandr, the fix looks good to me. Thanks, Alexander. On 12/01/2014 05:17 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8066142 webrev: http://cr.openjdk.java.net/~alexsch/8066142/webrev.00 This is a regression f