Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Pete Brunet
Here's the latest patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8055831/webrev.01/ The changes are: - restructured the native libraries from one directory to several directories on a per DLL/EXE basis - that impacted jdk/make/lib/Lib-jdk.accessibility.gmk - removed the source for the Ferret and

Re: [9] Review Request for 6866751: J2SE_Swing_Reg: the caret disappears when moving to the end of the line.

2015-03-24 Thread Sergey Bylokhov
24.03.15 9:10, Semyon Sadetsky wrote: What happens if the user will set the size/aspect of the caret via "putClientProperty" after the fix? It depends on specific Cursor implementation. Yes, but only DefaultCaret is uses these properties for drawing, because this is our class and we know that.

Re: [9] Review request for 8033000 No Horizontal Mouse Wheel Support In BasicScrollPaneUI

2015-03-24 Thread Sergey Bylokhov
Hi, Alexander. The fix looks fine to me. 23.03.15 17:08, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8033000 webrev: http://cr.openjdk.java.net/~alexsch/8033000/webrev.00 Shift modifier is added to for the horizontal scrollin

Re: [9] Review Request for 6921687: Mnemonic disappears after repeated attempts to open menu items using mnemonics

2015-03-24 Thread Alexander Scherbatiy
On 3/24/2015 9:24 AM, Semyon Sadetsky wrote: On 3/23/2015 5:36 PM, Alexander Scherbatiy wrote: On 3/23/2015 2:22 PM, Semyon Sadetsky wrote: Hello, Please review JDK9 fix. webrev: http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/6921687/webrev.00/ bug: https://bugs.openjdk.java.net/brows

Re: [9] Review Request for 8075314: All the InternalFrames will be maximized after maximizing only one of the InternalFrame with the special options "-client -Xmixed -Dswing.defaultlaf=com

2015-03-24 Thread Sergey Bylokhov
Hi, Semyon. The fix looks good. Since this is a jck issue I assume that this functionality was tested on all supported look and feels and the new test always passed. So I suggest to change the test and cover all l&f, to be sure that this bug will not be integrated back in some other/new looks

Re: [9] Review Request for 6921687: Mnemonic disappears after repeated attempts to open menu items using mnemonics

2015-03-24 Thread Anton Tarasov
Hi Semyon, On 23/03/15 14:48, Semyon Sadetsky wrote: +description When ALT PRESSED event comes for the second time it can be the case to clear menu focus and srokes or the case when ALT+key combination is about to be pressed. The last one was missed in the ALT key handler. I see nothing bad